test(ast/estree): check span offsets are converted in ascending order in ESTree conformance tests#10887
Merged
graphite-app[bot] merged 1 commit intomainfrom May 14, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10887 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
022f50c to
a71fdce
Compare
a71fdce to
a7b64c9
Compare
9b30a40 to
e1bc381
Compare
8133e5e to
35caa35
Compare
35caa35 to
cc8948c
Compare
e1bc381 to
5154db5
Compare
Member
Merge activity
|
… in ESTree conformance tests (#10887) Add a Cargo feature `conformance` to `oxc_ast_visit` crate. When this feature is enabled, it exposes a method `Utf8ToUtf16::convert_program_with_ascending_order_checks` which panics if span offsets are converted out of order. Use this feature and method in ESTree conformance tests. This ensures: 1. `Utf8ToUtf16Converter` visitor is functioning as intended. 2. All AST types have their fields ordered in order they appear in source code.
cc8948c to
2bdb338
Compare
5154db5 to
a05361e
Compare
Base automatically changed from
05-13-fix_ast_visit_fix_visitation_order_for_formalparameters_in_utf8toutf16converter_
to
main
May 14, 2025 01:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add a Cargo feature
conformancetooxc_ast_visitcrate.When this feature is enabled, it exposes a method
Utf8ToUtf16::convert_program_with_ascending_order_checkswhich panics if span offsets are converted out of order.Use this feature and method in ESTree conformance tests. This ensures:
Utf8ToUtf16Convertervisitor is functioning as intended.