fix(ast_visit): fix visitation order for BindingPattern in Utf8ToUtf16Converter#11003
Merged
graphite-app[bot] merged 1 commit intomainfrom May 14, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11003 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
05-12-fix_ast_visit_fix_visitation_order_for_bindingpattern_in_utf8toutf16converter_
branch
from
8133e5e to
3c210ef
Compare
overlookmotel
force-pushed
the
05-12-fix_ast_visit_fix_visitation_order_for_bindingpattern_in_utf8toutf16converter_
branch
from
3c210ef to
021aa8b
Compare
Contributor
Merge activity
|
…tf16Converter` (#11003) Fix visitation order in `Utf8ToUtf16Converter` to process span offsets in ascending order in `BindingPattern`. `type_annotation`'s span is within the span of `kind`, so need to visit `type_annotation` before processing span end of `kind`. The exception is `BindingRestElement`, where `type_annotation`'s span start is after `kind`'s span end.
graphite-app
bot
force-pushed
the
05-12-fix_ast_visit_fix_visitation_order_for_bindingpattern_in_utf8toutf16converter_
branch
from
021aa8b to
d0d04e3
Compare
graphite-app
bot
deleted the
05-12-fix_ast_visit_fix_visitation_order_for_bindingpattern_in_utf8toutf16converter_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix visitation order in
Utf8ToUtf16Converterto process span offsets in ascending order inBindingPattern.type_annotation's span is within the span ofkind, so need to visittype_annotationbefore processing span end ofkind. The exception isBindingRestElement, wheretype_annotation's span start is afterkind's span end.