refactor(ast/estree): add regex and bigint fields to all Literal nodes in ESTree AST#10877
Conversation
…` nodes in ESTree AST
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Actually... is this a good idea? I figured adding a field that ESTree doesn't have wouldn't break any user code - like TS-ESLint adds more fields to the AST. But... people might test for whether a 🤔 |
CodSpeed Instrumentation Performance ReportMerging #10877 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
Upon reflection, no it's not! Closing. |

Add
regexandbigintfields to allLiteralnodes, so allLiterals have a consistent object shape.Bump
acorn-test262, which performs the some alterations to AST in the test fixtures in oxc-project/estree-conformance#28.This is a divergence from both Acorn and TS-ESLint, but in my opinion it's likely a good idea regardless.