Skip to content

fix(ast/estree): fix TS type def for RegExpLiteral#10876

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-07-fix_ast_estree_fix_ts_type_def_for_regexpliteral_
May 7, 2025
Merged

fix(ast/estree): fix TS type def for RegExpLiteral#10876
graphite-app[bot] merged 1 commit intomainfrom
05-07-fix_ast_estree_fix_ts_type_def_for_regexpliteral_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 7, 2025

Fix TS type def for RegExpLiteral.

Problem is that we were defining interface RegExp. This name clashes with the native JS type RegExp which is used for the value field of RegExpLiteral. Get rid of this interface to remove the naming clash.

Copy link
Member Author

overlookmotel commented May 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels May 7, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 7, 2025 17:26
@codspeed-hq
Copy link

codspeed-hq bot commented May 7, 2025

CodSpeed Instrumentation Performance Report

Merging #10876 will not alter performance

Comparing 05-07-fix_ast_estree_fix_ts_type_def_for_regexpliteral_ (581d068) with main (e7228fa)

Summary

✅ 36 untouched benchmarks

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 7, 2025
Copy link
Member Author

overlookmotel commented May 7, 2025

Merge activity

Fix TS type def for `RegExpLiteral`.

Problem is that we were defining `interface RegExp`. This name clashes with the native JS type `RegExp` which is used for the `value` field of `RegExpLiteral`. Get rid of this interface to remove the naming clash.
@graphite-app graphite-app bot force-pushed the 05-07-fix_ast_estree_fix_ts_type_def_for_regexpliteral_ branch from b4e01f1 to 581d068 Compare May 7, 2025 18:03
@graphite-app graphite-app bot merged commit 581d068 into main May 7, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 05-07-fix_ast_estree_fix_ts_type_def_for_regexpliteral_ branch May 7, 2025 18:10
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant