feat: add regex and bigint fields to all Literal nodes#28
Closed
overlookmotel wants to merge 2 commits intomainfrom
Closed
feat: add regex and bigint fields to all Literal nodes#28overlookmotel wants to merge 2 commits intomainfrom
regex and bigint fields to all Literal nodes#28overlookmotel wants to merge 2 commits intomainfrom
Conversation
overlookmotel
force-pushed
the
05-07-feat_add_regex_and_bigint_fields_to_all_literal_nodes
branch
from
2e73f66 to
b831560
Compare
overlookmotel
force-pushed
the
05-07-feat_add_regex_and_bigint_fields_to_all_literal_nodes
branch
from
b831560 to
362e539
Compare
Member
Author
|
Decided this is a bad idea. See oxc-project/oxc#10877 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
regexandbigintfields to allLiteralnodes, so allLiterals have a consistent object shape.This is a divergence from both Acorn and TS-ESLint, but in my opinion it's likely a good idea regardless.