refactor(lexer): simplify macros for string parsing + correct comment#10039
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 28, 2025
Conversation
Member
Author
This was referenced Mar 25, 2025
CodSpeed Instrumentation Performance ReportMerging #10039 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
This was referenced Mar 25, 2025
Merged
7cd3f0a to
d0bcfca
Compare
e2cd64e to
e71b344
Compare
This was referenced Mar 27, 2025
e71b344 to
eb05e9e
Compare
d0bcfca to
d04b1b3
Compare
This was referenced Mar 27, 2025
Contributor
Merge activity
|
…#10039) Small simplification of `handle_string_literal!` macro in lexer. Correct one comment which was wrong.
eb05e9e to
95e69f6
Compare
d04b1b3 to
326b4df
Compare
Base automatically changed from
03-20-fix_ast_estree_fix_stringliteral_s_containing_lone_surrogates
to
main
March 28, 2025 04:49
This was referenced Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Small simplification of
handle_string_literal!macro in lexer. Correct one comment which was wrong.