Skip to content

refactor(lexer): simplify macros for string parsing + correct comment#10039

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-25-refactor_lexer_simplify_macros_for_string_parsing_correct_comment
Mar 28, 2025
Merged

refactor(lexer): simplify macros for string parsing + correct comment#10039
graphite-app[bot] merged 1 commit intomainfrom
03-25-refactor_lexer_simplify_macros_for_string_parsing_correct_comment

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 25, 2025

Small simplification of handle_string_literal! macro in lexer. Correct one comment which was wrong.

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 25, 2025
Copy link
Member Author

overlookmotel commented Mar 25, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 25, 2025

CodSpeed Instrumentation Performance Report

Merging #10039 will create unknown performance changes

Comparing 03-25-refactor_lexer_simplify_macros_for_string_parsing_correct_comment (326b4df) with main (6687f5b)

Summary

🆕 33 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.6 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.7 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.3 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.2 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.8 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.9 s N/A
🆕 mangler[antd.js] N/A 16 ms N/A
🆕 mangler[react.development.js] N/A 294.2 µs N/A
🆕 mangler[typescript.js] N/A 39.7 ms N/A
🆕 minifier[antd.js] N/A 165.6 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 291.6 ms N/A
🆕 estree[checker.ts] N/A 96.1 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 92.7 µs N/A
🆕 parser[antd.js] N/A 113.6 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@overlookmotel overlookmotel force-pushed the 03-25-refactor_lexer_simplify_macros_for_string_parsing_correct_comment branch from 7cd3f0a to d0bcfca Compare March 27, 2025 07:26
@overlookmotel overlookmotel force-pushed the 03-20-fix_ast_estree_fix_stringliteral_s_containing_lone_surrogates branch from e2cd64e to e71b344 Compare March 27, 2025 07:26
@overlookmotel overlookmotel force-pushed the 03-20-fix_ast_estree_fix_stringliteral_s_containing_lone_surrogates branch from e71b344 to eb05e9e Compare March 27, 2025 07:44
@overlookmotel overlookmotel force-pushed the 03-25-refactor_lexer_simplify_macros_for_string_parsing_correct_comment branch from d0bcfca to d04b1b3 Compare March 27, 2025 07:44
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 27, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 28, 2025

Merge activity

…#10039)

Small simplification of `handle_string_literal!` macro in lexer. Correct one comment which was wrong.
@graphite-app graphite-app bot force-pushed the 03-20-fix_ast_estree_fix_stringliteral_s_containing_lone_surrogates branch from eb05e9e to 95e69f6 Compare March 28, 2025 04:30
@graphite-app graphite-app bot force-pushed the 03-25-refactor_lexer_simplify_macros_for_string_parsing_correct_comment branch from d04b1b3 to 326b4df Compare March 28, 2025 04:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 28, 2025
Base automatically changed from 03-20-fix_ast_estree_fix_stringliteral_s_containing_lone_surrogates to main March 28, 2025 04:49
@graphite-app graphite-app bot merged commit 326b4df into main Mar 28, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 03-25-refactor_lexer_simplify_macros_for_string_parsing_correct_comment branch March 28, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant