fix(codegen): do not escape $ in strings unless using backtick as quote

[overlookmotel]

When printing "${", it's unnecessary to escape the $ unless the quote character is a backtick.

[overlookmotel]

• perf(codegen): speed up printing StringLiterals #10046
• ci(codegen): add benchmark for minified printing #10109
• fix(codegen): do not escape $ in strings unless using backtick as quote #10103 👈 (View in Graphite)
• fix(codegen): prevent arithmetic overflow calculating quote for StringLiterals #10102
• perf(codegen): faster printing quotes #10080
• refactor(codegen): print string literals containing lone surrogates without reference to raw #10044
• fix(parser): store lone surrogates as escape sequence #10041
• test(minifier): update cargo minsize snapshot #10105
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10103 will create unknown performance changes

_{Comparing 03-28-fix_codegen_do_not_escape_in_strings_unless_using_backtick_as_quote (9b6e344) with 03-28-fix_codegen_prevent_arithmetic_overflow_calculating_quote_for_stringliteral_s (c903e42)}

Summary

🆕 33 new benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
🆕	codegen[checker.ts]	N/A	22.6 ms	N/A
🆕	codegen_sourcemap[checker.ts]	N/A	65.7 ms	N/A
🆕	isolated-declarations[vue-id.ts]	N/A	58.3 ms	N/A
🆕	lexer[RadixUIAdoptionSection.jsx]	N/A	21.5 µs	N/A
🆕	lexer[antd.js]	N/A	24.8 ms	N/A
🆕	lexer[cal.com.tsx]	N/A	5.9 ms	N/A
🆕	lexer[checker.ts]	N/A	14.8 ms	N/A
🆕	lexer[pdf.mjs]	N/A	3.9 ms	N/A
🆕	linter[RadixUIAdoptionSection.jsx]	N/A	2.7 ms	N/A
🆕	linter[cal.com.tsx]	N/A	1.2 s	N/A
🆕	linter[checker.ts]	N/A	2.9 s	N/A
🆕	mangler[antd.js]	N/A	16 ms	N/A
🆕	mangler[react.development.js]	N/A	294.5 µs	N/A
🆕	mangler[typescript.js]	N/A	39.7 ms	N/A
🆕	minifier[antd.js]	N/A	165.6 ms	N/A
🆕	minifier[react.development.js]	N/A	1.8 ms	N/A
🆕	minifier[typescript.js]	N/A	291.6 ms	N/A
🆕	estree[checker.ts]	N/A	96.9 ms	N/A
🆕	parser[RadixUIAdoptionSection.jsx]	N/A	92.4 µs	N/A
🆕	parser[antd.js]	N/A	113.2 ms	N/A
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

[overlookmotel]

The effect on output sizes is odd. Output for antd.js is 78 bytes shorter after this PR (before minification), but the gzipped size is slightly larger. Whereas typescript.js is smaller both with/without gzip.

Edit: Actually I can't replicate the larger gzipped size locally.

cargo run -p oxc_minifier --example minifier target/antd.js -- --mangle --nospace > out.js
gzip -9 out.js

That produces 5 bytes shorter output after this PR. So I don't understand why oxc_minsize reports the gzipped size as increasing. @Boshen?

[graphite-app]

Merge activity

• Mar 29, 8:29 AM EDT: Boshen added this pull request to the Graphite merge queue.
• Mar 29, 9:11 AM EDT: A user merged this pull request with the Graphite merge queue.