fix(ast/estree): fix StringLiterals containing lone surrogates#10036
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 28, 2025
Merged
Conversation
Member
Author
CodSpeed Instrumentation Performance ReportMerging #10036 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
1b964b5 to
e2cd64e
Compare
This was referenced Mar 25, 2025
Merged
hi-ogawa
reviewed
Mar 25, 2025
e2cd64e to
e71b344
Compare
This was referenced Mar 27, 2025
e71b344 to
eb05e9e
Compare
This was referenced Mar 27, 2025
Contributor
Merge activity
|
) Improve output for `StringLiteral`s containing lone surrogates. Most of the remaining failing tests are just due to difference in case e.g.: ```diff - "value": "\ud83d", + "value": "\uD83D", ``` But there are still a few genuine test fails. We don't have it exactly right yet. But this is a step in the right direction.
eb05e9e to
95e69f6
Compare
This was referenced Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Improve output for
StringLiterals containing lone surrogates.Most of the remaining failing tests are just due to difference in case e.g.:
But there are still a few genuine test fails. We don't have it exactly right yet. But this is a step in the right direction.