Skip to content

fix(ast/estree): fix StringLiterals containing lone surrogates#10036

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-20-fix_ast_estree_fix_stringliteral_s_containing_lone_surrogates
Mar 28, 2025
Merged

fix(ast/estree): fix StringLiterals containing lone surrogates#10036
graphite-app[bot] merged 1 commit intomainfrom
03-20-fix_ast_estree_fix_stringliteral_s_containing_lone_surrogates

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 25, 2025

Improve output for StringLiterals containing lone surrogates.

Most of the remaining failing tests are just due to difference in case e.g.:

- "value": "\ud83d",
+ "value": "\uD83D",

But there are still a few genuine test fails. We don't have it exactly right yet. But this is a step in the right direction.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Mar 25, 2025
Copy link
Member Author

overlookmotel commented Mar 25, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review March 25, 2025 14:39
@overlookmotel overlookmotel requested a review from hi-ogawa March 25, 2025 14:40
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 25, 2025

CodSpeed Instrumentation Performance Report

Merging #10036 will create unknown performance changes

Comparing 03-20-fix_ast_estree_fix_stringliteral_s_containing_lone_surrogates (95e69f6) with main (cd1f035)

Summary

🆕 33 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.6 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.6 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.3 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.2 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.8 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.9 s N/A
🆕 mangler[antd.js] N/A 16 ms N/A
🆕 mangler[react.development.js] N/A 294.6 µs N/A
🆕 mangler[typescript.js] N/A 39.7 ms N/A
🆕 minifier[antd.js] N/A 165.6 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 291.6 ms N/A
🆕 estree[checker.ts] N/A 96.1 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 92.7 µs N/A
🆕 parser[antd.js] N/A 113.6 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@overlookmotel overlookmotel force-pushed the 03-20-fix_ast_estree_fix_stringliteral_s_containing_lone_surrogates branch from e2cd64e to e71b344 Compare March 27, 2025 07:26
@overlookmotel overlookmotel force-pushed the 03-20-fix_ast_estree_fix_stringliteral_s_containing_lone_surrogates branch from e71b344 to eb05e9e Compare March 27, 2025 07:44
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 27, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 28, 2025

Merge activity

)

Improve output for `StringLiteral`s containing lone surrogates.

Most of the remaining failing tests are just due to difference in case e.g.:

```diff
- "value": "\ud83d",
+ "value": "\uD83D",
```

But there are still a few genuine test fails. We don't have it exactly right yet. But this is a step in the right direction.
@graphite-app graphite-app bot force-pushed the 03-20-fix_ast_estree_fix_stringliteral_s_containing_lone_surrogates branch from eb05e9e to 95e69f6 Compare March 28, 2025 04:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 28, 2025
@graphite-app graphite-app bot merged commit 95e69f6 into main Mar 28, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 03-20-fix_ast_estree_fix_stringliteral_s_containing_lone_surrogates branch March 28, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants