Skip to content

css: drop @supports color fallbacks that a later declaration of the same property replaces - #45560

Closed
robobun wants to merge 5 commits into
mainfrom
robobun/e2586397/css-drop-replaced-color-fallbacks
Closed

robobun wants to merge 5 commits into
mainfrom
robobun/e2586397/css-drop-replaced-color-fallbacks

Conversation

@robobun

@robobun robobun commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

  • .x{color:var(--c,lab(50% 20 30));color:red} builds to .x{color:red} and two @supports rules with copies of the first declaration. They follow the rule, so that declaration wins.
  • add_unparsed_fallbacks (src/css/context.rs:310) stages a copy per color tier, and minify_style_arm prints them behind the rule.

Fix

  • A later declaration of the same property drops the staged copies: a typed color or text-shadow that every target accepts, a value with var(), or inherit, initial, unset, revert.
  • The drop reads only the copies staged since that property's first copy.
  • An ignored rule follows a rule that lost each copy, so the next rule stays apart (second commit).
  • Verified: 54 new tests in test/js/bun/css/css.test.ts, 36 fail on main. Self-reviewed: 8 concerns raised, 2 addressed, the ignored rule is open (Notes).

Background

  • A var() value with a color wider than sRGB prints in sRGB. @supports rules behind the rule hold a copy per tier (P3, LAB).
  • CssRuleList::minify merges a rule into the style rule before it. The printer skips CssRule::Ignored, a non-style rule.
  • Weighed: a merge-state flag (lost when a merged @media list is minified again), a rule cut at the later declaration (Notes).
Notes

A decision for a maintainer: the ignored rule. On main the @supports rules sit behind the style rule, so the next rule never merges into it. Without them it does, and that merge has faults on main, with no color involved:

The second commit pushes a CssRule::Ignored behind a rule that lost each copy. CssRuleList::minify passes it through as a non-style rule, also when two @media rules with one query merge and their rules are minified again. So each output of this PR is the output of main without the dropped copies.

The self-review prefers the other order: no ignored rule, and this PR lands after #42042, #42101 and #43240, because the faults belong to the merge. That is this PR without its second commit. Without that commit, .x{color:var(--c,lab(50% 20 30));color:red}.x{all:unset;color:var(--z)} ends in color:var(--z);all:unset until #42042 lands. Say which one you want and I will leave only that. If the ignored rule stays, it can go when the merge faults are fixed.

Why those values. A browser that reads a copy must keep the later declaration at parse time. If it drops the declaration, the copy is the right winner.

  • var(), inherit, initial, unset and revert are older than color() and lab() in each browser (caniuse-lite 1.0.30001636: revert is Chrome 84, Firefox 67, Safari 9.1, and color(display-p3) is Safari 10.1, Chrome 111, Firefox 113).
  • env() does not count: Safari reads it from 11.1. revert-layer does not count: Safari reads it from 15.4.
  • An empty var() fallback does not count. WebKit rejected it until r279358 (bug 227368, June 2021), so Safari 14, a default target of bun build, reads a P3 copy and drops color:var(--d,).
  • A var() fallback with ; or ! at its top level is not a <declaration-value>, and the name -- is reserved. No browser keeps those.
  • The parser keeps VAR() and ENV() as plain functions, so a value with one does not count.

The report. It has five rules. On main the copies of the first declaration win in all five. With this PR they win in two.

rule main this PR
.x{color:var(--c,lab(50% 20 30));color:red} copies win .x{color:red}
.x{color:var(--c,lab(50% 20 30));color:var(--d)} copies win .x{color:var(--d)}
.x{color:var(--c,lab(50% 20 30));color:inherit} copies win .x{color:inherit}
.x{background-color:var(--bg,oklch(70% 0.1 200));background:none} copies win as on main
.x{border-color:var(--b,oklch(70% 0.1 200));border:0} copies win as on main

What the drop does. A later declaration drops every staged copy of its property that has the same importance, then stages its own copies. .x{color:var(--c,lab(50% 20 30));color:var(--d,oklch(70% .1 200))} printed both copies in each @supports rule. It now prints the copy of --d only, which won there before too.

The bound. Each declaration adds at most one copy to a list. staged counts the declarations of the rule that staged a copy, and Copied.since holds that count at the first copy of a property and importance. The drop reads the last staged - since copies of each list. An entry that lost each copy stays in place, so the order of the P3 rule and the LAB rule does not depend on a drop.

A rule with nested rules. Main splits such a rule in two around its @supports rules. A rule that lost each copy is not split. It prints as main prints a rule that never had copies.

What is not in this PR. A first version also cut the style rule in front of a later declaration that only competes with a copy: a shorthand after a copied longhand, a longhand after a copied shorthand, all, and a value that a target can reject. It fixes the last two rules of the table. A review of that version asked for this split:

The branch is robobun/e2586397/css-supports-copies-order. A smaller next step is a drop in the typed arms of the background, border and box-shadow handlers.

The typed rule trusts the compat table. Where the table has a hole (a system color other than AccentColor, the units rex, rch, ric, rcap), main already drops the earlier declaration from the rule, and this PR drops its copies too.

Reviews. A review of the first push found that the drop scanned every staged copy (one rule with 20,000 staged copies and 20,000 replaced declarations took 3.4 s), that a dropped entry could flip the order of the two @supports rules, and that the next rule merged into the rule. All three are fixed. The self-review of this push raised 8 concerns:

Fuzz. Main against this build.

  • A cascade model with three browser classes (sRGB, P3, P3 and LAB) over 380,000 sheets in seven shapes, default targets of bun build: 0 sheets go from right to wrong, 54,195 go from wrong to right.
  • 300,000 flat sheets with the default targets and 60,000 single rules over ten target sets: each output is the output of main with declarations removed from generated @supports rules, and nothing else.
  • 40,000 nested sheets over ten target sets: 21,567 differ by dropped copies only. 258 print the same rules in another order and 54 keep a rule that main removes as a duplicate, both through the unsplit rule above.
  • Debug build with ASAN: 40,000 of these sheets, no report, output equal to the release build.

Other open PRs and upstream. lightningcss 1.33.0 prints the same two @supports rules for the first rule of the table. The ltr and rtl rules of logical properties (#38623) and the dark rules of light-dark() have the same order fault and are not changed. lightningcss has an open PR, parcel-bundler/lightningcss#1287, that adds remove_conditional_property in the same shape for custom properties. This fault is not reported upstream yet.

Measurements. Release builds of main 5866b5f and of this PR with one toolchain. The container has no perf and no valgrind. Each count is a gdb single-step count or a gdb breakpoint hit count.

Instructions per minify_style_arm call (one style rule, with its declarations):

rule main this PR
.x{margin:0;padding:0} 4,937 4,942
.x{color:red;color:blue} 4,152 4,158
.x{color:var(--c);color:var(--d)} 4,748 4,761
.x{color:var(--c,lab(50% 20 30))}, first rule of a sheet that stages a copy 13,865 13,973
the same rule as the second and third rule of the sheet 10,808 and 11,214 10,830 and 11,236
.x{color:var(--c,lab(50% 20 30));color:red} 14,195 11,069
.x{color:var(--c,lab(50% 20 30));color:var(--d)} 14,511 11,437
  • The 15 sheets in test/js/bun/css/files: 20,780 rules and 4,120 add_unparsed_fallbacks calls on both. The three new functions are entered 0 times. The counted allocator entry points are hit 77,533 times on both. The output is byte-identical for 15 of 15.
  • daisyUI 5.7.47 daisyui.css: 2,580,870 to 2,579,118 bytes. The 12 dead @supports rules of the 6 ::picker(select) rules are gone (74 to 62 generated rules), and nothing else changes. Allocations 111,937 to 111,836.
  • Time for one rule, N = 5,000, 10,000 and 20,000, median of five runs:
rule main this PR
N pairs color:var(--c,lab(50% 20 30));color:red 16, 31, 72 ms 10, 19, 39 ms
N box-shadow:foo(Npx lab(50% 20 30)), which all stay staged, then N such pairs 36, 79, 181 ms 29, 66, 138 ms
the same N copies, then N color:var(--cN,lab(50% 20 30)) 38, 80, 149 ms 32, 61, 123 ms
a staged copy, then a pair, N times 43, 86, 182 ms 34, 71, 143 ms
ten properties get a copy, N copies follow, each of the ten is replaced 24, 47, 90 ms 24, 47, 93 ms
  • Release binary: .text 81,071,045 to 81,074,629 bytes (size -A), +3,584. The file is one page larger, +4,096 bytes.

Suites. Debug build: css.test.ts 1,368 pass, 69 skip, 3 todo, 0 fail. Release build of this branch: 2,754 pass, 69 skip, 3 todo, 0 fail in the 29 files of test/js/bun/css/ and test/bundler/css/, and 56 pass, 1 todo in test/bundler/esbuild/css.test.ts.

Downsides

  • Not fixed: a typed background, border, box-shadow or light-dark() value, a shorthand after a copied longhand, all, text-shadow:none.
  • The next rule does not merge into a rule that lost its copies, as on main.
  • +5 instructions per style rule, +13 per declaration that stages copies. .text +3,584 bytes.

[human-review] gate passed · iteration 0 · 5 files touched

fails on main (without fix)
ASAN without fix: 36 failed, 72 skipped
$ BUN_DEBUG_QUIET_LOGS=1 bun scripts/build.ts --profile=debug --quiet test "--reporter=junit" "--reporter-outfile=/tmp/pr_gate.xml" test/js/bun/css/css.test.ts
bun test v1.4.4 (367d939d9)

test/js/bun/css/css.test.ts:
Output .flexrow {
  flex-direction: row;
}

.flexcol {
  flex-direction: column;
}

.hello {
  flex-wrap: wrap;
}

.world {
  flex-wrap: nowrap;
}

(pass) css tests > .flexrow {
	flex-direction: row;
}

.flexcol {
	flex-direction: column;
}

.hello {
	flex-wrap: wrap;
}

.world {
	flex-wrap: nowrap;
} [4.94ms]
Output .foo {
  content: "+";
}

(pass) css tests > .foo {
  content: "\2b";
} [1.03ms]
Output div {
  --foo: 1 1 1 #0101011a, 2 2 2 #02020233;
  --bar: 1 1 1 #01010116, 2 2 2 #02020233;
}

(pass) css tests > custom property cases > div {
        --foo: 1 1 1 rgba(1, 1, 1, 0.1), 2 2 2 rgba(2, 2, 2, 0.2);
        --bar: 1 1 1 #01010116, 2 2 2 #02020233;
      } [0.98ms]
Output :root {
  --my-color: red;
  --my-bg: white;
  --my-font-size: 16px;
}

.element {
  color: var(--my-color);
  background-color: var(--my-bg);
  font-size: var(--my-font-size);
}

(pass) css tests > custom property cases > :root {
        --my-color: red;
        --my-bg: wh
... (truncated)

release without fix: 60 failed, 72 skipped
bun test v1.4.3-canary.1 (367d939d9)

test/js/bun/css/css.test.ts:
Output .flexrow {
  flex-direction: row;
}

.flexcol {
  flex-direction: column;
}

.hello {
  flex-wrap: wrap;
}

.world {
  flex-wrap: nowrap;
}

(pass) css tests > .flexrow {
	flex-direction: row;
}

.flexcol {
	flex-direction: column;
}

.hello {
	flex-wrap: wrap;
}

.world {
	flex-wrap: nowrap;
} [0.78ms]
Output .foo {
  content: "+";
}

(pass) css tests > .foo {
  content: "\2b";
} [0.21ms]
Output div {
  --foo: 1 1 1 #0101011a, 2 2 2 #02020233;
  --bar: 1 1 1 #01010116, 2 2 2 #02020233;
}

(pass) css tests > custom property cases > div {
        --foo: 1 1 1 rgba(1, 1, 1, 0.1), 2 2 2 rgba(2, 2, 2, 0.2);
        --bar: 1 1 1 #01010116, 2 2 2 #02020233;
      } [0.06ms]
Output :root {
  --my-color: red;
  --my-bg: white;
  --my-font-size: 16px;
}

.element {
  color: var(--my-color);
  background-color: var(--my-bg);
  font-size: var(--my-font-size);
}

(pass) css tests > custom property cases > :root {
        --my-color: red;
        --my-bg: white;
        --my-font-size: 16px;
      }
      .element {
        color: var(--my-color);
        background-color: var(--my-bg);
        font-size: 
... (truncated)
passes on PR (with fix)
ASAN with fix: 72 skipped
$ BUN_DEBUG_QUIET_LOGS=1 bun scripts/build.ts --profile=debug --quiet test "--reporter=junit" "--reporter-outfile=/tmp/pr_gate.xml" test/js/bun/css/css.test.ts
rustup spent 7s installing the pinned toolchain (nightly-2026-09-15); it was missing or incomplete on this machine
bun test v1.4.4 (367d939d9)

test/js/bun/css/css.test.ts:
Output .flexrow {
  flex-direction: row;
}

.flexcol {
  flex-direction: column;
}

.hello {
  flex-wrap: wrap;
}

.world {
  flex-wrap: nowrap;
}

(pass) css tests > .flexrow {
	flex-direction: row;
}

.flexcol {
	flex-direction: column;
}

.hello {
	flex-wrap: wrap;
}

.world {
	flex-wrap: nowrap;
} [8.64ms]
Output .foo {
  content: "+";
}

(pass) css tests > .foo {
  content: "\2b";
} [15.70ms]
Output div {
  --foo: 1 1 1 #0101011a, 2 2 2 #02020233;
  --bar: 1 1 1 #01010116, 2 2 2 #02020233;
}

(pass) css tests > custom property cases > div {
        --foo: 1 1 1 rgba(1, 1, 1, 0.1), 2 2 2 rgba(2, 2, 2, 0.2);
        --bar: 1 1 1 #01010116, 2 2 2 #02020233;
      } [2.64ms]
Output :root {
  --my-color: red;
  --my-bg: white;
  --my-font-size: 16px;
}

.element {
  color: var(--my-color);
  background-color: var(--my-bg);
  font-size: var
... (truncated)

release with fix: 72 skipped
$ bun scripts/build.ts --profile=release
rustup spent 9s installing the pinned toolchain (nightly-2026-09-15); it was missing or incomplete on this machine
[configured] bun-profile → bun (stripped)
  target       linux-x64-gnu
  build type   Release
  build dir    ./build/release
  revision     56c23fe12f
  features     lto, baseline

23 deps, 204 codegen, 1207 objects in 17513ms

ninja: Entering directory `/workspace/bun/build/release'
[1/4] fetch rust-argon2
[rust-argon2] up to date
[2/4] fetch lolhtml
[lolhtml] up to date
[2/4] cargo plan → /workspace/bun/build/release/rust-target/plan.json
268 units: 194 lib, 16 proc-macro (host), 20 custom-build (host), 16 run custom-build, 17 lib (host), 4 run custom-build (host), 1 rlib
[3/4] reconfigure
[1/1564] mkdir stamps
[2/1564] mkdir codegen
[3/1564] gen bake.{client,server,error}.js
-> bake.client.js, bake.server.js, bake.error.js
[4/1564] install /workspace/bun
bun install v1.4.3-canary.1 (367d939d9)

Checked 22 installs across 44 packages (no changes) [8.07s]
[5/1564] install /workspace/bun/packages/bun-error
bun install v1.4.3-canary.1 (367d939d9)

Checked 1 install across 2 packages (no changes) [688.00ms]
[6/
... (truncated)
diff hotspot
src/css/context.rs                   |  94 +++++++++++++++++
 src/css/properties/custom.rs         |  54 ++++++++++
 src/css/properties/prefix_handler.rs |   3 +
 src/css/rules/mod.rs                 |   8 ++
 test/js/bun/css/css.test.ts          | 192 +++++++++++++++++++++++++++++++++++
 5 files changed, 351 insertions(+)

gate history · 1 passed · 0 rejected · iteration 0

evidence per changed file
file                                  reads  edits  tests
src/css/context.rs                        2      0    117
src/css/properties/custom.rs              0      0    115
src/css/properties/prefix_handler.rs      0      0    115
src/css/rules/mod.rs                      3      0    116
test/js/bun/css/css.test.ts               2      1    115

…ame property replaces

An unparsed declaration with a color wider than sRGB is printed in sRGB,
and its P3 and LAB copies are staged for @supports rules that follow the
style rule. There the copies beat a later declaration of the same
property: .x{color:var(--c,lab(50% 20 30));color:red} printed
.x{color:red} and two @supports rules that set the var() value again.

The staged copies of a property are now dropped when a later declaration
of that property replaces the value in each browser that reads a copy:
a typed color or text-shadow that every target accepts, or an unparsed
value that holds var() or is inherit, initial or unset. An unparsed value
keeps the copies of the tiers it stages a copy of its own for.

The drop runs in two cold functions behind supports.is_empty(), and only
in the declaration pass of the rule itself.

lightningcss 1.33.0 prints the copies.
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: oven-sh/bun/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 3d5e7ee1-afd3-4a11-b410-a5bede29ab5c
📥 Commits

Reviewing files that changed from the base of the PR and between 5866b5f and d890fd9.

📒 Files selected for processing: 5
  • src/css/context.rs
  • src/css/properties/custom.rs
  • src/css/properties/prefix_handler.rs
  • src/css/rules/mod.rs
  • test/js/bun/css/css.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

Walkthrough

The CSS minifier now tracks generated @supports fallback copies by property and importance. It removes matching copies when a later value is valid at parse time, and adjusts style-rule output after retraction.

Changes

CSS conditional fallback retraction

Layer / File(s) Summary
Validate values and track conditional copies
src/css/properties/custom.rs, src/css/context.rs
TokenList checks whether values are valid at parse time. PropertyHandlerContext tracks staged fallbacks and retracts matching copies when a valid replacement is processed.
Integrate retraction with style-rule output
src/css/properties/prefix_handler.rs, src/css/context.rs, src/css/rules/mod.rs, test/js/bun/css/css.test.ts
Property replacement triggers retraction. Empty @supports entries are omitted, and style-rule processing uses the retraction state. Tests cover removal and preservation of copies, rule ordering, and style-rule merging.

Suggested reviewers: jarred-sumner

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to d890f

The minifier now removes @supports color fallback copies when a later declaration of the same property replaces them. This fixes output where stale fallbacks overrode the later value. The changes are narrowly scoped and covered by new tests for removal, preservation, ordering, and rule merging. No merge-blocking issues were found.

Pre-merge checks: Passed 4
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly and concisely describes the main change: removing replaced @supports color fallback copies.
Description check Passed The description is complete and relevant. It explains the problem, the fix, known limitations, design decisions, performance impact, and verification results. It does not use the template headings exa…
Full details: Description check

Explanation

The description is complete and relevant. It explains the problem, the fix, known limitations, design decisions, performance impact, and verification results. It does not use the template headings exactly, but it provides the required information in equivalent sections.

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@robobun

robobun commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator Author
Updated 7:05 PM PT - Oct 19th, 2026

❌ @robobun, your commit 56c23fe has 1 failures in Build #129081 (All Failures):


🧪   To try this PR locally:

bunx bun-pr 45560

That installs a local version of the PR into your bun-45560 executable, so you can run:

bun-45560 --bun

@robobun

robobun commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator Author

Reproduced on main 5866b5f and on the 1.4.2 release, before the change:

$ printf '.x{color:var(--c,lab(50%% 20 30));color:red}' > a.css && bun build --minify a.css
.x{color:red}@supports (color:color(display-p3 0 0 0)){.x{color:var(--c,color(display-p3 .598686 .422118 .293048))}}@supports (color:lab(0% 0 0)){.x{color:var(--c,lab(50% 20 30))}}

With this PR the output is .x{color:red}.

The tests are in test/js/bun/css/css.test.ts (block "@supports color fallbacks and a later declaration of the same property"). 36 of the 54 fail on main.

CI on the diff is green: 180 of the 181 jobs of build #129081 pass, on Linux, Windows and macOS. The one red test is test/cli/bake/bake.test.ts on Windows 2019 x64 (ECONNREFUSED from the bake server in "bun --check bake starts the server once the type errors are fixed"). This PR does not touch it. The red tests of the build before (#128173) were install, module graph, node:http and worker tests, and they pass in #129081.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the inline findings, I also checked the !important tier split in retract_conditional (a non-important later declaration only touches entry.declarations, so !important copies survive, and the copied bookkeeping scans both tiers before dropping the id) and the copied lifecycle (initialised in new/child, cleared in the reset path alongside supports) — neither showed a problem.

Extended reasoning...

The change adds a copied: Vec<PropertyId> field and two cold retraction methods to the CSS minifier's PropertyHandlerContext, wires the typed FallbackHandler arm to call one of them, adds TokenList::is_valid_at_parse_time in custom.rs, and adds 38 tests. It touches no security-sensitive surface. The inline findings include a confirmed behavioral regression from same-selector rule merging and several partial-fix gaps across sibling handlers, and the hunt stopped at its bug cap, so a human maintainer should weigh the design before this merges.

Findings marked 🟡 are optional suggestions and need no follow-up push.

Comment thread src/css/context.rs Outdated
Comment thread src/css/context.rs Outdated
Comment thread test/js/bun/css/css.test.ts Outdated
Comment thread src/css/properties/prefix_handler.rs
Comment thread src/css/properties/custom.rs Outdated
Comment thread src/css/properties/prefix_handler.rs
Comment thread src/css/context.rs Outdated
Comment thread src/css/properties/custom.rs Outdated
A later declaration now drops each staged copy of its property that has
the same importance, then stages its own copies. Each declaration adds
at most one copy to a list, so the drop reads only the copies staged
since the first copy of that property. One rule with 20,000 staged
copies of another property and 20,000 replaced `color` declarations
took 3.4 s. It now takes 138 ms, against 181 ms on main.

An entry that lost each copy stays in place, so the order of the two
`@supports` rules does not depend on a drop.

`revert` counts as valid at parse time. `env()`, a function named `VAR`
or `ENV`, a `var()` with the name `--`, and a `var()` fallback with `;`
or `!` do not.
The `@supports` rules behind a style rule kept the next rule from a
merge into it. That merge moves `all` and unparsed values in front of
the declarations they follow (#42042, #42101), and a merge of two rules
with equal declarations takes the selector away from the copies of the
second rule. An ignored rule now follows a rule that lost each copy, so
the next rule stays a rule of its own, as before.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

The two newest commits address the merge-reorder, bounded-retraction, revert, and exact-assertion points from my earlier review. Beyond the inline finding, I also checked that the re-minify of a previously merged block (which runs with DeclarationContext::None while the next rule's copies are staged) cannot retract those copies — add_unparsed_fallbacks returns early and retract_conditional is gated on StyleRule — and that the recent = staged - since window is sound, since every push into a SupportsEntry list goes through add_unparsed_fallbacks, which bumps staged. The new CssRule::Ignored barrier in minify_style_arm mirrors the existing non-style-rule arm, and the style_rules index map tolerates it the same way it tolerates the appended @ supports rules.

Extended reasoning...

The change adds a per-rule ledger of copied properties to PropertyHandlerContext, a retraction hook in FallbackHandler, three token-list predicates in custom.rs, and a merge barrier in rules/mod.rs, with 38 new exact-output test rows; it touches no security-sensitive surface. It is a cascade-semantics change in the CSS minifier with a merge-state interaction, so a human maintainer should still weigh the mechanism, and the typed background/border/box-shadow arms and shorthand/longhand cases remain unhandled by the author's own account.

Additional findings (outside the current diff — GitHub can't attach inline comments there):

  • 🟣 src/css/rules/mod.rs — pre-existing: when a rule that still has staged @ supports copies merges its selectors into the previous rule, the copies are printed with an empty selector, invalid CSS that P3/LAB browsers drop. The selector merge in merge_style_rules takes sty.selectors.v (src/css/rules/mod.rs:1179) before get_supports_rules clones them at src/css/rules/mod.rs:774, so the copy rule becomes @ supports (...){{color:...}}. The new Ignored barrier at src/css/rules/mod.rs:899 only covers the retracted case. Fix: build the @ supports and logical extras from the selectors as they were before the merge (snapshot like incompatible_decls at mod.rs:713), or skip the selector merge while the handler context has staged supports/ltr/rtl/dark entries.

    Why this was flagged

    Input .x{color:var(--c,#a16945)}.y{color:var(--c,lab(50% 20 30))} minified with the test targets (chrome 87, safari 14). .y minifies to color:var(--c,#a16945) and stages P3 and LAB copies in src/css/context.rs:356. At src/css/rules/mod.rs:723-742 merge_style_rules finds the declarations equal (mod.rs:1158) and moves .y into the previous rule with core::mem::take(&mut src.selectors.v) at mod.rs:1179. get_supports_rules at mod.rs:774 then deep-clones the now-empty style_rule.selectors (src/css/context.rs:158) and mod.rs:881 appends @ supports (color:color(display-p3 0 0 0)){{color:var(--c,color(display-p3 ...))}} with no selector. The user gets .x,.y{color:var(--c,#a16945)} followed by selector-less @ supports blocks that browsers reject, so .y never gets its wide-gamut color. The base branch prints the same; the diff's barrier at mod.rs:899 fires only when retracted is set.

    Verification: pre-existing. merge_style_rules at src/css/rules/mod.rs:1158 finds equal declarations and at mod.rs:1179 does core::mem::take(&mut src.selectors.v), emptying .y's selector list. Only afterwards does mod.rs:774 call get_supports_rules, which clones the now-empty selectors at context.rs:158. The new barrier at mod.rs:898-903 is gated on retracted, so it does not fire here.

@robobun

robobun commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

The empty selector after a selector merge is on main too, with no copies dropped: .x{color:var(--c,#a16945)}.y{color:var(--c,lab(50% 20 30))} prints the same there. #43240 (open) keeps the selectors on these rules, so this PR does not change it. The ignored rule only keeps a rule that lost its copies out of that merge, so that this PR does not add a new way into the fault.

Jarred-Sumner added a commit that referenced this pull request Oct 27, 2026
### What does this PR do?

Consolidates the open pull requests on the CSS parser (`src/css`:
parsing, minifying, lowering, printing, CSS modules) into one.

179 open pull requests were in scope. Each was judged by one rule: **the
output must mean to a browser what the input meant.** Every claim was
run through a build of `main`, a build with the change, lightningcss
1.33 and Chromium 156 (CSSOM, computed values, painted pixels for colors
and gradients), and counted against 10,116 real stylesheets: the
published CSS of about 190 popular npm packages, plus stylesheets from
open source repositories. 107 land here, whole or in part, most of them
cut down. The source diff is net negative.

Of the 10,116, 9,509 are stylesheets that someone ships. The rest are
test fixtures of other tools (521), Tailwind v4 source that needs its
plugin (59) and SCSS, PostCSS or template source (27).

| 9,509 shipped stylesheets | `main` | this branch |
|---|---|---|
| fail to build | 71 | 35 |
| ... of those, valid CSS that Bun rejects | | 0 |
| minified output reads differently in Chromium than the input | 552 | 2
|
| CSS modules with a name that is referenced but not defined, or
exported but not defined | 166 | 0 |

| all 10,116 | `main` | this branch |
|---|---|---|
| fail to build | 192 | 141 |
| minified output reads differently in Chromium than the input | 593 |
15 |
| build on `main`, fail here | | 0 |
| right on `main`, wrong here (minified, and at the default targets) | |
0 |
| size of the minified output, no targets | 162.32 MB | 162.47 MB
(+0.093%) |
| size of the output at the default targets | 224.1 MB | 210.2 MB
(-6.2%) |

A syntax error is a build error, with one exception: the IE star hack
`*zoom: 1` is skipped, because tachyons and handsontable ship it. The 35
shipped stylesheets that fail are invalid CSS: 28 have a selector that
Chromium drops (semantic-ui-css, swiper, @ionic/core, Adobe Spectrum,
xp.css), 2 an `@import` after other rules, and one each `@supports not X
and Y`, a nested `@keyframes`, a stray comma, a selector list in
`::slotted()`, `@media screen\0` (govuk-frontend). The 2 that read
differently fold a `color-mix()` inside a gradient (see the known gaps).

The growth of the minified output is rules and declarations that `main`
deleted by mistake: 87 KB of rules, 45 KB of prefixed declarations that
only browser targets can rule out.

#### Popular CSS that `main` breaks today

- normalize.css, modern-normalize, sanitize.css: `font-family:
monospace, monospace` is collapsed to `monospace`, which changes the
font size from 16px to 13px (#46662).
- CKEditor 5, Tabler, Carbon, VitePress, Ionic, PatternFly, Excalidraw:
a rule of custom properties is deleted as a "duplicate" of a later rule
with the same selector and other custom properties. 37 stylesheets lose
1,681 custom properties (#33684).
- Material Components, daisyUI, DocSearch, plyr: a `var()` size loses to
its own fallback (#42101).
- nextra, daisyUI, CKEditor: declarations written after a nested rule
are moved above it (#45462).
- antd 4, purecss, govuk-frontend: browser hacks in selector lists start
to apply everywhere (#42100).
- foundation-sites, flatpickr, 98.css, blueprintjs, scalar,
react-datepicker: the build fails on valid CSS (#46756, #38552, #38534).
tachyons, handsontable: it fails on the IE star hack (#46751).
- nodejs.org, Mantine: a CSS module exports classes that no rule
defines, because the `@apply` or `@mixin` in them is moved out of the
rule (#46759).
- hint.css and 42 more: `z-index: 1000001` and `1000000` become the same
number (#46715).
- Adobe Spectrum: `--version: 5.0.1` prints as `5.1`.
- A quarter of all stylesheets: minified output has a stray space in
`align-items: center` (#41993).

#### Behavior changes to look at first

1. **`light-dark()` is kept as written at the default browser targets**
(#42009). The lowered form `var(--buncss-light, a) var(--buncss-dark,
b)` is invalid unless a compiled `color-scheme` covers the element: 184
of the 215 real stylesheets that get it never define the variable, so
every browser drops the declaration. The docs section on the polyfill is
removed.
2. **`border` is not built from longhands** (#42072):
`border-width:0;border-style:solid;border-color:red` stays three
declarations, because `border` also resets `border-image`. 305 real
stylesheets grow by 30 KB in total; `bootstrap.min.css` by 113 bytes, 5
gzipped. No real stylesheet was found where the old merge shows, so this
is the one to drop if size matters more. 14 existing expectations
change.
3. **A CSS module no longer exports names that only occur inside
`:global(...)`** (#45487). 73 real modules lose 202 export keys, all of
them names that no rule has. `import { g }` or `composes: g` of such a
name becomes a build error.
4. **Container names and `@counter-style` names stay global in a CSS
module** (#45247 by @mikamikasuki). `main` hashes the `@container` name
but not `container-name`, so a named query never matches.
postcss-modules (Vite, css-loader, Next.js) keeps them global;
lightningcss and esbuild hash both. Global keeps a container that is
queried from another file or from JS working.
5. **Syntax errors are build errors, also two that `main` lets
through**: a media query that stops short (`@media screen and {`,
`@media not {`, `@import "a.css" screen and;`) and `@media (width <) foo
{`. No stylesheet of the 10,116 has either. A condition that is valid by
the grammar though no browser knows it, `( ... )` or `fn( ... )`, is
kept as written (#46756): `(min-width:0\0)`, `(not(hover))`.
6. **Declarations after a nested rule stay where they were written**, as
a nested declarations rule (#45462). Changes the output of 199 real
stylesheets; in a fuzz of 2,850 nested programs compared by computed
style, `main` was wrong in 1,056 and the pull request's code, before it
was trimmed here, in none.
7. **`Bun.color`**: `color()` inputs are converted instead of returned
as a string (`Bun.color("color(srgb 1 0 0)", "hex")` was `"color(srgb 1
0 0)"`); `currentColor`, system colors and `light-dark()` give `null` in
the converting formats instead of the keyword as a string; a relative
color or `color-mix()` outside sRGB is clipped, not gamut-mapped
(`hsl(from oklch(100% .399 336.3) h s l)` is `#ff5bff`, was `#fff`).
8. The `:-moz-any()` and `:-webkit-any()` copies of rules with `:is()`
are gone at the default targets (#45945, #42029). The `:-webkit-any()`
copy outranked the original rule: `.title{color:blue}
:is(h1,h2,h3){color:red}` painted red. 5.8% of all default-target output
was the `:-moz-any()` copies.
9. `Property` grows from 216 to 224 bytes: `Url` stores its text as a
slice so that two `url()` values can be compared (#46895). The pull
request packed a pointer and a `u32` behind `unsafe` to avoid that.

#### Not in this PR, needs a decision

- **Raise the default browser targets (#40369) and add a `cssTarget`
option (#40368).** Today: Chrome 80, Edge 80, Firefox 78, Safari 14,
Opera 67, and no public way to change them. At Vite 8's floor the output
of the 9,924 stylesheets is 15.3% smaller (3.9% gzipped). About a dozen
fixes here only matter at today's floor, and code for older targets is
unreachable without the option.
- Vendor prefixes for `user-select`, `appearance`, `hyphens` and five
more (#45814): 1,116 real stylesheets lack a prefix they need at the
default targets. And for `backdrop-filter` (#44648): 173.
- Clip instead of gamut-map in the sRGB fallback of a plain wide-gamut
color: deletes about 90 lines, changes every pinned fallback hex. If the
mapping stays, #44647 by @oddharsh makes it closer to what browsers
paint (colors off by 2/255 or more: 168 to 110 of 3,170 real ones).

#### Changes

**Rules: duplicates, merging, nesting, fallbacks**

- The `:-moz-any()` copy of every rule with `:is()` or `:not(a, b)` is
gone: Firefox 78 has `:is()` (#45945). 1,164 real stylesheets
- Keep declarations written after a nested rule in place with a nested
declarations rule (#45462). 379 real stylesheets
- With nesting compiled away, an unknown at-rule inside a style rule was
moved out of it: `.wrapper{@apply flex}` printed a bare `@apply flex;`
and the rule was gone, so a CSS module exported a class that no rule
defines. It now stays in a block under the compiled selector. 72 real
modules with Tailwind's `@apply`, 25 with Mantine's `@mixin` (#46759).
316 real stylesheets
- Keep !important in the rules generated for logical properties and
color-scheme (#38597). 311 real stylesheets
- With browser targets, remove an earlier duplicate rule only when its
declaration block is equal (#46861). 171 real stylesheets
- Compare custom property names in `PropertyId` equality and importance
in duplicate-rule detection (#33684). 40 real stylesheets
- Keep same-condition @supports rules and empty named @layer blocks
(#46733). 31 real stylesheets
- Keep target-added vendor prefix passes on cloned and re-minified
rules, and never print a bare `:full-screen` (#43339). 12 real
stylesheets
- Keep the selectors on rules added for color fallbacks and logical
properties (#43240). 3 real stylesheets
- A later declaration of a property drops the `@supports` color copies
of the earlier one, which printed after the rule and won (#45560). 2
real stylesheets
- Do not merge style rules in a stylesheet that holds `revert-rule`
(#46953). 1 real stylesheets
- `@import ... supports(-webkit-mask: none)` kept its prefix (#38589)

**Properties and shorthands**

- Print align-items:center without a stray space when no safe/unsafe
keyword is given (#41993). 3,317 real stylesheets
- Emit the physical longhands instead of the inset shorthand for targets
without it (#38583). 1,452 real stylesheets
- Keep the stops of an upward gradient as written, and drop a `50%` hint
only at the midpoint (#46790). 104 real stylesheets
- Emit unparsed border-block-* declarations when compiling logical
borders (#38582). 89 real stylesheets
- Keep repeated font families and dedupe only the inserted system-ui
fallbacks (#46662). 88 real stylesheets
- A `width` / `height` / `min-*` / `max-*` with `var()` or `env()` was
printed before the plain fallback written above it, so the fallback won
(#42101). 26 real stylesheets
- Keep box-orient and box-direction when flex-direction or flex-flow
follows (#45672). 16 real stylesheets
- Write held prefixed background declarations at every flush (#46882). 6
real stylesheets
- Derive equality for Size2D and BorderRadius, and keep every prefix in
the border-radius handler (#45665). 2 real stylesheets
- Print `none` instead of an empty border-image, mask-border or
mask-box-image value (#45143). 2 real stylesheets
- Keep font/transition sub-properties on the side of the shorthand they
were written on (#41990). 2 real stylesheets
- CSS-wide keywords are not names: `font:12px Arial;font-family:inherit`
printed `font:12px inherit`, `color-scheme:inherit` and
`color-scheme:auto` printed `normal`, `transition-property:unset` was
folded into `transition` (#42022). 2 real stylesheets
- Only fold font longhands into `font` when the rule declared a `font`
(#45459)
- Keep a font family name quoted when its identifiers do not read back
as the same name (#46606)
- Stop rewriting valid positions into ones browsers reject (#45197)
- `border` is no longer built from longhands unless the rule also sets
what `border` resets (`border-image`), and an author's `border-image`
reset is no longer dropped. `transition` is likewise only written where
the rule wrote one, because it resets `transition-behavior` (#42072)
- `border; border-image: <gradient>; border-image-slice: 1` lost the
gradient in every default build (#42018)
- A prefixed `linear-gradient` keeps its direction, written or
generated: the prefixed syntax names the starting side and measures
angles differently (#46697)

**At-rules**

- Print @font-face format() keywords as strings (#37979). 439 real
stylesheets
- Print @supports `not` conditions without a leading space (#38559). 88
real stylesheets
- Reset after the number token of a unicode-range (#45835). 33 real
stylesheets
- Keep `<general-enclosed>` media and container conditions as written
(#46756). 24 real stylesheets
- A strict range such as `(width < 768px)` lowered for old targets still
matched at exactly 768px. The step is now `.02px`. The `not all and`
form for other units is not taken (#46806). 18 real stylesheets
- Keep scanning an @supports condition after a nested block (#38552). 9
real stylesheets
- Every `@counter-style name` printed as `@counter-stylename`, which
browsers drop (also #46692). In a CSS module the name now stays global,
like the `list-style` that refers to it (#33679). 9 real stylesheets
- Keep a keyframe whose block has an invalid item (#46288). 2 real
stylesheets
- Read an @Property initial-value on the stylesheet's parser, keep an
unmatched value as written (#45806). 2 real stylesheets
- `@media {}` is `all`. A media query that stops after `and`, `or` or
`not` (`@media screen and {`) is a build error; `main` printed `not all`
or dropped the condition, silently. The `@layer` and type selector parts
are not taken (#46869). 2 real stylesheets
- Accept a name-only `@container` and a `style()` feature with no value
(#46689). 1 real stylesheets
- Parse `<timeline-range-name> <percentage>` keyframe selectors (#45652)
- Allow `or` inside parentheses after a media type (#45088)
- Print the `=` comparison in media and container queries as `=`
(#45071)
- Parse the @font-palette-values font-family descriptor as a list of
family names (#45484)

**Selectors**

- Never wrap a selector list in :is() (#46787). 414 real stylesheets
- Stop emitting :-webkit-any() copies of :is() that outrank the original
rule (#42029). 373 real stylesheets
- With browser targets, a selector list with a vendor-prefixed member
was split, which revives hacks that rely on other engines dropping the
whole list: `.s *::-ms-backdrop,.s{flex:auto}` applied everywhere.
Rewritten; the list is printed as written (#42100). 42 real stylesheets
- Print the vendor prefix on downleveled :any-link, :read-only,
:read-write, :placeholder-shown and :autofill (#42131). 12 real
stylesheets
- Fix nesting lowering of a `&` that does not lead its selector
(#43047). 8 real stylesheets
- `@scope`: `&` and implicit selectors compile to `:where(:scope)`,
relative selectors and bare declarations parse (#43165). 7 real
stylesheets
- Only reject bare :global / :local pseudo-classes in CSS modules
(#38534). 5 real stylesheets
- Stop truncating `@scope to (...)` and stop replacing `&` in the
scope-end selector (#43146). 2 real stylesheets
- `[xl|href$=".pdf"]` lost its namespace prefix (#45159). 2 real
stylesheets
- Match An+B keywords exactly and take only `+` as the leading sign
(#42953). 1 real stylesheets
- Parse ::details-content and ::picker() like ::part() (#45504). 1 real
stylesheets
- Parse :window-inactive as an ordinary pseudo-class, and accept it
after ::selection (#45815)
- Print :nth-col(1) and :nth-last-col(1) in functional form (#41575)
- `li::before::marker` failed the build (#45810)
- `&` inside `:nth-child(... of S)` is resolved when nesting is compiled
away. The second selector serializer (326 lines) is deleted (#43024)

**Colors and `Bun.color`**

- Keep light-dark() as written under the default browser targets
(#42009). 227 real stylesheets
- Number and percentage channels parse in `lab()`, `lch()`, `oklab()`,
`oklch()`, `hsl()` and `hwb()`; the hue of `lch` / `oklch` is no longer
scaled by alpha (#45084). 130 real stylesheets
- `Bun.color` returns `null` for `currentColor`, system colors and
`light-dark()` in the converting formats, instead of the CSS keyword as
a string (#33047). 130 real stylesheets
- Relative colors: channel keywords are on the scale of their function
(`rgb(from #369 calc(r + 10) g b)`), the origin's alpha is kept, a
relative color kept as written gets no `@supports` copies, and a result
outside sRGB is not folded (#45362). 31 real stylesheets
- Keep rotate: 0deg out of none, and keep the origin alpha in relative
colors (#38486). 13 real stylesheets
- Compute the D50 reference white in f32 so greys convert to lab(l 0 0)
like lightningcss (#38535). 7 real stylesheets
- Return a missing hue for a grey from conversions into lch, oklch, hsl
and hwb (#45201). 5 real stylesheets
- Fix color(a98-rgb), srgb-linear relative colors and color-mix(in
xyz-d50) (#38487). 4 real stylesheets
- Match named colors without regard to ASCII case (#45092). 3 real
stylesheets
- Fold min(), max() and clamp() over plain numbers (#39515)
- `calc(l - .08)` in a percentage channel of a relative color became NaN
and printed `#000` (also #45970) (#45971)
- Bun.color: convert color() inputs instead of returning them as a CSS
string (#38488)
- A `color-mix(in srgb, ...)` result outside sRGB prints `color(srgb
...)` instead of a gamut-mapped hex (#39269)

**`calc()` and numbers**

- Rounding to 6 significant digits ate into the integer part:
`z-index:2147483647` became `2147480000`, `max-width:9999999px` became
`10000000px`, `--x:1234567.5` became `1234570`. It now only cuts a
fraction short: a value kept as tokens prints its source text, a typed
value prints every integer digit and at least one digit of the fraction
(#46715). 43 real stylesheets
- A number without a unit is no longer repaired into `px`
(`height:1.5715` is dropped by a standards-mode browser, so it prints as
written), `calc(-1 * 0)` is not a length, and on a property of the range
[0,∞] (sizes, border radii, padding, border and outline widths, gap,
`flex-basis`, `font-size`) a `calc()` that folds below zero prints `0`
instead of an invalid negative literal, and a negative literal no longer
replaces the valid declaration before it (`width:10px;width:-5px`
printed `width:-5px`) (#42104). 24 real stylesheets
- Print numbers from the f32's shortest digits, not its f64 expansion
(#38565). 17 real stylesheets
- Print negative numbers below 1 with a single minus sign (#38516)
- Keep math functions over two different length units as written
(#38489)
- Fold rem() with a truncated quotient, so it keeps the sign of the
dividend (#32286)
- A one-argument `min()` / `max()` around a sum printed without any
function (`width:100% - 20px`) (#46145)
- `round()` breaks ties upward and handles a negative step as browsers
do (#45249)

**CSS modules**

- A CSS module exports its `@keyframes` names (`styles.spin`). Hashing
is unchanged (#46720). 145 real stylesheets
- A name inside `:global(...)` prints plain but was exported as
`name_<hash>`, a class no rule has (also #38573) (#45487). 90 real
stylesheets
- Keep container names global in CSS modules (#45247). 6 real
stylesheets
- Tag the keyframes name when an `animation` value falls back to raw
tokens (#46034). 6 real stylesheets
- In a plain stylesheet `composes: a from "./b.css"` was treated as an
import: the file was inlined and an absolute path printed (#45961). 4
real stylesheets
- Drop a rejected composes instead of failing the file at print time
(#38538). 1 real stylesheets
- Keep every rule's custom properties for the composes conflict check
(#38523)
- Keep composes working after a nested rule in the same block (#38520)
- `IdentOrRef::hash` read 2 of 16 bytes, so in release builds every
class of a module hashed alike (#30784)

**Tokens, `url()`, diagnostics**

- The block skip stack no longer allocates on every block exit (#39533)
- Report the diagnostic's line without its line breaks in
position.lineText (#38342). 192 real stylesheets
- Compare `url()` values by their text (#46895). 26 real stylesheets
- Values kept as tokens keep the blanks they were written with instead
of having them re-invented at print time: `attr(x type(<number>))`
printed `type(< number> )`, which browsers drop. Minified output still
drops the blanks that cannot matter (#45577). 19 real stylesheets
- The IE star hack (`*zoom:1`) failed the whole build. The declaration
is skipped, as every browser does. It is the one syntax error that
builds: tachyons, handsontable and jasmine ship it (#46751). 8 real
stylesheets
- The path of a copied asset spliced into `url()` is always quoted, so a
file name with a space or a parenthesis cannot end the `url()` (#41557).
7 real stylesheets
- Move the skip loop of parse_until_before out of the generic body
(#39520)
- Remove dead code from bun_css: the unused `impl Default for Property`
(#45618)
- Default the at-rule and qualified-rule parser traits, drop the
url_to_css shim (#31999)

**Speed**

Four inputs that took quadratic or exponential time, or produced output
out of proportion, are now linear, with no new limit and no extra pass
(#31639, #42243, #38531, #43421).

**Tests only**

- `css-fuzz.test.ts` never ran in CI and timed out on debug builds; it
is a deterministic table now (#38500)
- `nth-anplusb-ident.test.ts` counts heaps in a child process (#46331)
- `color.test.ts` checks the ansi-16 sweep with one `expect()` (#42824)
- Not CSS, but it failed this PR's CI and fails on `main` too:
`ws-proxy.test.ts` on Windows, "a message sent during a TLS
renegotiation arrives after it". The helper server now renegotiates from
the callback of the frame's write (#46170)

**No pull request covered these**

- `--v: 5.0.1` printed as `5.1`, `--w: 1.0.0` as `10`, `--x: 1+2` as
`12`, `2n+1` as `2n1`: a number token that touches another keeps its
source text.
- `color-scheme: auto` printed as `normal`, and `color-scheme: dark
light` as `light dark`.
- A bare `:global` or `:local` in a CSS module sets the scope of the
names after it, up to the end of the selector, as in css-loader. It was
a build error.
- The scrollbar states (`a:horizontal`,
`::-webkit-scrollbar{&:horizontal{}}`) are valid in a plain compound, as
in WebKit and Blink.
- Without browser targets, `-webkit-box-align`, `-ms-flex-align` and the
like were dropped next to their standard form (flatpickr,
foundation-sites, materialize-css: 28 stylesheets), and
`-webkit-fill-available` before `-moz-available` (beercss).
- `(-o-min-device-pixel-ratio: 2/1)` printed as `2`.
- `sin()`, `cos()` and `tan()` are exact at multiples of 90deg:
`calc(100px * cos(90deg))` printed `-.00000437114px`.
- A `display-p3` color at targets that have P3 but not the other
`color()` spaces (Safari 10.1 to 14) got itself as a fallback.
- `width: rem(-18px, 5px)` folds to a negative literal once `rem()` is
right; it prints `0`.
- Consecutive nested declarations rules, which arise when same-query
`@media` blocks in one rule merge, are folded into one and count against
the existing selector expansion limit as the `&{}` rules they replace
did.

#### Known and not fixed here

- Four longhands are still folded into a `transition` the author did not
write where the targets add a prefixed copy of a property (`mask-image`
at Chrome 80): only the shorthand gives the copy its own times.
- A later `background`, `box-shadow` or `border-*` declaration still
loses to the `@supports` copy of an earlier `var()` value of the same
property with a wide-gamut color. Same on `main`; #45560 is taken for
the properties of the fallback handler and for unparsed values only.
- A merged rule prints the unprefixed name in the passes of the rule it
absorbed: `.d::-webkit-input-placeholder{}.d::-moz-placeholder{}` prints
`::placeholder` for the second (#42106, not taken: it breaks the merge
of prefix-equivalent rules).
- The `border`, `outline` and `font` shorthands, `line-height`,
`scroll-padding`, `background-size` and a few more still print a
`calc()` that folds below zero as a negative literal. No real stylesheet
has one.
- `all` is not a property Bun knows, so `a{margin-top:1px;all:unset}`
prints `all` first. Same on `main`.
- A selector kept as raw tokens loses the blank before `*` when
minified: `--sel: .dark *` prints `.dark*`. Same on `main`.
- `width:calc(0% + 12px)` folds to `12px`, which lays out differently in
a table cell. Same on `main`.
- The `:dir()` / `:lang()` rules of a lowered logical property print
before the nested rules of their rule, so a logical declaration written
after a nested rule of equal specificity still loses to it. Same on
`main`.
- A fraction is still rounded to 6 significant digits (`12345.678`
prints `12345.7`, `33.3333333333%` prints `33.3333%`). Keeping every
digit would add up to 282 KB over the corpus.
- `@keyframes "quoted"` is hashed in a module but not exported.
- In a module, a keyframes name inside a `var()` fallback is not hashed:
`animation: var(--enter, fade 1s)`. Same on `main`.
- A `color-mix()` or relative color folded to a hex inside a gradient
changes the interpolation from Oklab to sRGB (VS Code, clawhub).
Printing `color(srgb ..)` instead needs a fallback for `mask-image`,
`list-style-image` and custom properties at the default targets, which
have none.
- A comma list in `@container` still fails the build.
- After a bare `:global`, names that are hashed at print time
(`::view-transition-old(foo)`) are still hashed; inside `:global(...)`
they are not.

#### Pull requests in scope that do not land here

- Duplicates of a pull request that lands here: #36961 (of #37979),
#38478 (of #46662), #38480 (of #46733), #38482 (of #46715), #38491 (of
#38500), #38508 (of #45201), #38513 (of #45362), #38573 (of #45487),
#38640 (of #38500), #45525 (of #45247), #45589 (of #46756), #45970 (of
#45971)
- Already fixed on `main`: #38674
- Right, but for input nobody writes (0 of 10,116 stylesheets, and not
new syntax): #31916, #38526, #38592, #39349, #41139, #41801, #42042,
#42484, #43078, #45604, #45908, #46086, #46221, #46224, #46273, #46694,
#46707, #46737, #46755, #46816, #46870, #46934
- Right or harmless, but not worth their code, their bigger output or
the behavior they change: #30905, #31924, #33332, #34426, #36225,
#38006, #38512, #38547, #38551, #38561, #38572, #38576, #38607, #38623,
#38667, #38692, #42106, #42912, #42918, #43407, #43434, #44700, #45442,
#45546, #45747, #45759, #45825, #45946, #46061, #46127, #46206
- Need a decision (see above), stay open: #40368, #40369, #44647,
#44648, #45814
- Stays open: #45787

Out of scope: CSS linking and chunking in the bundler, the dev server,
docs-only pull requests, and repository-wide sweeps that touch `src/css`
in passing.

Thanks to @mikamikasuki (#45247), @alii (#39520, #31999) and @oddharsh,
whose measurements on #40369 and #41990 were used.

Fixes #16727.
Fixes #24770.
Fixes #30772.
Fixes #44704.
Fixes #45089.
Fixes #45237.
Fixes #46872.

### How did you verify your code works?

- The 35 CSS test files pass on a debug build, also with
`FORCE_COLOR=1`. 600+ of the tests in this branch fail on a build of
`main`. An earlier head of this branch passed all 179 CI jobs that ran.
- The reproduction of each issue listed above was run on `main` (wrong)
and on this branch (right).
- Differential run over the 10,116 stylesheets, `main` against this
branch, minified without targets and through `Bun.build` at the default
targets: no stylesheet that builds on `main` fails; Chromium 156
compares the output with the input rule by rule (CSSOM, then computed
values on a sized element in a standards-mode document, colors as
painted pixels in sRGB and P3). The comparison has 195 control pairs
that must read equal or different. For stylesheets that read differently
on both builds, mostly because of lowering, the sets of differences were
compared; the three new ones are two minifier fixtures that are wrong on
both and one comparison artifact.
- CSS modules are checked for consistency instead, since hashed names
defeat the comparison: every reference points at a name the output
defines, every export exists.
- `Bun.color`: 59 inputs in 13 formats on both builds; every changed
cell was read.
@Jarred-Sumner

Copy link
Copy Markdown
Collaborator

Part of this landed in #47025 (7942008). Its description says what was taken.

A later declaration of a property drops the @supports color copies of the earlier one, which printed after the rule and won. 2 real stylesheets

@robobun

robobun commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator Author

Verified on main at 7942008: .x{color:var(--c,lab(50% 20 30));color:red} prints .x{color:red}, and the var(--d) and inherit forms print without the copies too.

One difference from this PR, for the record. The drop that landed runs for each later unparsed declaration, with no test for whether a browser keeps that declaration. So .x{color:var(--c,lab(50% 20 30));color:var(--d,)} now prints .x{color:var(--d,)} with no copies. WebKit rejected an empty var() fallback until r279358 (bug 227368, June 2021), so Safari 14, a default target, drops that declaration and used the P3 copy before. I expect no real stylesheet has this shape, so I am not opening a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants