Skip to content

fix: Fix incompatibility with latest @types/node - #23307

Merged
alii merged 2 commits into
mainfrom
ali/fix-types-6oct
Oct 6, 2025
Merged

alii merged 2 commits into
mainfrom
ali/fix-types-6oct

Conversation

@alii

@alii alii commented Oct 6, 2025

Copy link
Copy Markdown
Member

No description provided.

@robobun

robobun commented Oct 6, 2025 •

Copy link
Copy Markdown
Collaborator
Updated 3:30 PM PT - Oct 6th, 2025

❌ @alii, your commit 9d8e177 has some failures in Build #28201 (All Failures)


🧪   To try this PR locally:

bunx bun-pr 23307

That installs a local version of the PR into your bun-23307 executable, so you can run:

bun-23307 --bun

@alii
alii merged commit 3c232b0 into main Oct 6, 2025
8 of 10 checks passed
@alii
alii deleted the ali/fix-types-6oct branch October 6, 2025 22:29
@coderabbitai

coderabbitai Bot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Updates Bun type declarations: adds conditional CompressionStream/DecompressionStream typings tied to lib.dom availability; declares corresponding global variables; replaces an empty DOMException interface with a concrete var including constructor and constants. Test fixture adjusts to use global crypto, removing a node:crypto import and type reference.

Changes

Cohort / File(s) Summary
Bun types: streams and DOMException
packages/bun-types/globals.d.ts
Added LibEmptyOrNodeStreamWebCompressionStream/DecompressionStream types; declared CompressionStream/DecompressionStream globals via UseLibDomIfAvailable; replaced empty DOMException interface with full declare var DOMException (constructor, prototype, constants); updated related comments.
Integration test: crypto fixture
test/integration/bun-types/fixture/crypto.ts
Removed import "crypto" alias and nodeCrypto.webcrypto.CryptoKey reference; switched to using the global crypto object directly; no exported API changes.

Suggested reviewers

  • Jarred-Sumner
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ali/fix-types-6oct

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 166c8ff and 9d8e177.

⛔ Files ignored due to path filters (1)
  • test/bun.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • packages/bun-types/globals.d.ts (4 hunks)
  • test/integration/bun-types/fixture/crypto.ts (0 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants