Skip to content

node: v24.7 - #73793

Merged
typescript-bot merged 15 commits into
DefinitelyTyped:masterfrom
Renegade334:node-24.7
Oct 6, 2025
Merged

typescript-bot merged 15 commits into
DefinitelyTyped:masterfrom
Renegade334:node-24.7

Conversation

@Renegade334

Copy link
Copy Markdown
Contributor

No description provided.

@Renegade334
Renegade334 marked this pull request as ready for review October 2, 2025 17:18
@typescript-bot

typescript-bot commented Oct 2, 2025 •

Copy link
Copy Markdown
Contributor

@Renegade334 Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 73793,
  "author": "Renegade334",
  "headCommitOid": "ec66b8ac6f2c51347602f1eec20016de18f19b98",
  "mergeBaseOid": "8e274af6ed512811d15426cca3b946cd9227a255",
  "lastPushDate": "2025-10-01T16:18:29.000Z",
  "lastActivityDate": "2025-10-06T07:32:03.000Z",
  "mergeOfferDate": "2025-10-02T22:10:01.000Z",
  "mergeRequestDate": "2025-10-06T07:32:03.000Z",
  "mergeRequestUser": "Renegade334",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/fs.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/http.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/http2.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/inspector.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/inspector.generated.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/node/sqlite.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/stream/web.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/crypto.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/globals-non-dom.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/http.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/http2.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/sqlite.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/test.ts",
          "kind": "test"
        },
        {
          "path": "types/node/ts5.6/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/ts5.7/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/web-globals/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/web-globals/streams.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "jkomyno",
        "r3nya",
        "btoueg",
        "touffy",
        "mohsen1",
        "galkin",
        "eps1lon",
        "WilcoBakker",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina",
        "Semigradsky",
        "Renegade334",
        "anonrig"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Mirzaa1234512345",
      "date": "2025-10-05T09:59:46.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2025-10-02T22:09:21.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 3362249345,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels Oct 2, 2025
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Review in Pull Request Status Board Oct 2, 2025
@typescript-bot

Copy link
Copy Markdown
Contributor

🔔 @microsoft @jkomyno @r3nya @btoueg @Touffy @mohsen1 @galkin @eps1lon @WilcoBakker @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky @anonrig — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Comment thread types/node/crypto.d.ts
* @since v16.7.0
*/
randomUUID(): UUID;
CryptoKey: CryptoKeyConstructor;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just never existed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it did prior to v19.0.0

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* never documented to exist 😉

Comment thread types/node/stream/web.d.ts
Comment thread types/node/fs.d.ts
*/
export function cpSync(source: string | URL, destination: string | URL, opts?: CopySyncOptions): void;

// TODO: collapse

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover?

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 2, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in Pull Request Status Board Oct 2, 2025
@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Oct 5, 2025
@Renegade334

Copy link
Copy Markdown
Contributor Author

Ready to merge.

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Oct 6, 2025
@typescript-bot
typescript-bot merged commit 6ce715f into DefinitelyTyped:master Oct 6, 2025
15 checks passed
alii added a commit to oven-sh/bun that referenced this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Critical package Maintainer Approved Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants