Repository navigation
Enable CHECK_REF_COUNTED_LIFECYCLE - #121
Merged
Merged
Conversation
Member
Author
|
/build-preview |
|
🔄 Preview build started Release tag: |
WalkthroughTwo WebKit files remove Bun-specific preprocessor conditionals. The WasmMemory.h file unconditionally includes assertion logic in checkLifetime(), while RefCountDebugger.h simplifies CHECK_REF_COUNTED_LIFECYCLE to depend solely on assertion and security settings, removing the prior Bun-specific branch. Changes
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🧰 Additional context used🧠 Learnings (3)📓 Common learnings📚 Learning: 2025-10-01T01:58:56.267ZApplied to files:
📚 Learning: 2025-10-01T01:58:28.399ZApplied to files:
🔇 Additional comments (1)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
|
This may have been caused by a newer build being triggered for the same PR. |
Member
Author
|
/build-preview |
|
🔄 Preview build started Release tag: |
|
✅ Preview build completed Release: autobuild-preview-pr-121-f24072bb |
Jarred-Sumner
pushed a commit
to oven-sh/bun
that referenced
this pull request
Dec 27, 2025
### What does this PR do? Enables `CHECK_REF_COUNTED_LIFECYCLE` in WebKit ( oven-sh/WebKit#121 ) See also WebKit/WebKit@a978fae #### `CHECK_REF_COUNTED_LIFECYCLE`? A compile-time macro that enables lifecycle validation for reference-counted objects in debug builds. **Definition** ```cpp #if ASSERT_ENABLED || ENABLE(SECURITY_ASSERTIONS) #define CHECK_REF_COUNTED_LIFECYCLE 1 #else #define CHECK_REF_COUNTED_LIFECYCLE 0 #endif ``` **Purpose** Detects three categories of bugs: 1. Missing adoption - Objects stored in RefPtr without using adoptRef() 2. Ref during destruction - ref() called while destructor is running (causes dangling pointers) 3. Thread safety violations - Unsafe ref/deref across threads **Implementation** When enabled, RefCountDebugger adds two tracking flags: - m_deletionHasBegun - Set when destructor starts - m_adoptionIsRequired - Cleared when adoptRef() is called These flags are checked on every ref()/deref() call, with assertions failing on violations. **Motivation** Refactored debug code into a separate RefCountDebugger class to: - Improve readability of core refcount logic - Eliminate duplicate code across RefCounted, ThreadSafeRefCounted, etc. - Simplify adding new refcount classes **Overhead** Zero in release builds - the flags and checks are compiled out entirely. ### How did you verify your code works? --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
liooil
pushed a commit
to liooil/poly
that referenced
this pull request
Aug 7, 2026
### What does this PR do? Enables `CHECK_REF_COUNTED_LIFECYCLE` in WebKit ( oven-sh/WebKit#121 ) See also WebKit/WebKit@a978fae #### `CHECK_REF_COUNTED_LIFECYCLE`? A compile-time macro that enables lifecycle validation for reference-counted objects in debug builds. **Definition** ```cpp #if ASSERT_ENABLED || ENABLE(SECURITY_ASSERTIONS) #define CHECK_REF_COUNTED_LIFECYCLE 1 #else #define CHECK_REF_COUNTED_LIFECYCLE 0 #endif ``` **Purpose** Detects three categories of bugs: 1. Missing adoption - Objects stored in RefPtr without using adoptRef() 2. Ref during destruction - ref() called while destructor is running (causes dangling pointers) 3. Thread safety violations - Unsafe ref/deref across threads **Implementation** When enabled, RefCountDebugger adds two tracking flags: - m_deletionHasBegun - Set when destructor starts - m_adoptionIsRequired - Cleared when adoptRef() is called These flags are checked on every ref()/deref() call, with assertions failing on violations. **Motivation** Refactored debug code into a separate RefCountDebugger class to: - Improve readability of core refcount logic - Eliminate duplicate code across RefCounted, ThreadSafeRefCounted, etc. - Simplify adding new refcount classes **Overhead** Zero in release builds - the flags and checks are compiled out entirely. ### How did you verify your code works? --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We disable
CHECK_REF_COUNTED_LIFECYCLEtemporary to build latest WebKit.But we can enable it now.