[sosukesuzuki]

What does this PR do?

Enables CHECK_REF_COUNTED_LIFECYCLE in WebKit ( oven-sh/WebKit#121 )

See also WebKit/WebKit@a978fae

CHECK_REF_COUNTED_LIFECYCLE?

A compile-time macro that enables lifecycle validation for reference-counted objects in debug builds.

Definition

  #if ASSERT_ENABLED || ENABLE(SECURITY_ASSERTIONS)
  #define CHECK_REF_COUNTED_LIFECYCLE 1
  #else
  #define CHECK_REF_COUNTED_LIFECYCLE 0
  #endif

Purpose

Detects three categories of bugs:

1. Missing adoption - Objects stored in RefPtr without using adoptRef()
2. Ref during destruction - ref() called while destructor is running (causes dangling pointers)
3. Thread safety violations - Unsafe ref/deref across threads

Implementation

When enabled, RefCountDebugger adds two tracking flags:

• m_deletionHasBegun - Set when destructor starts
• m_adoptionIsRequired - Cleared when adoptRef() is called

These flags are checked on every ref()/deref() call, with assertions failing on violations.

Motivation

Refactored debug code into a separate RefCountDebugger class to:

• Improve readability of core refcount logic
• Eliminate duplicate code across RefCounted, ThreadSafeRefCounted, etc.
• Simplify adding new refcount classes

Overhead

Zero in release builds - the flags and checks are compiled out entirely.

How did you verify your code works?

[robobun]

^{Updated 12:47 AM PT - Dec 27th, 2025}

❌ @sosukesuzuki, your commit 36a8179 has 3 failures in Build #33787 (All Failures):

• test/bake/dev/stress.test.ts - 1 failing on 🐧 25.04 x64
• test/js/bun/test/parallel/test-http-should-emit-close-when-connection-is-aborted.ts - timeout on 🪟 2019 x64-baseline
• test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 14 aarch64

---

🧪   To try this PR locally:

bunx bun-pr 25705

That installs a local version of the PR into your bun-25705 executable, so you can run:

bun-25705 --bun

[coderabbitai]

Walkthrough

Updates the default WebKit version hash in the CMake configuration and modifies memory management in the serialization bindings. The WebKit version is bumped from one commit hash to another, and the memory deallocation mechanism is changed from direct deletion to reference counting.

Changes

Cohort / File(s)	Summary
WebKit version configuration cmake/tools/SetupWebKit.cmake	Updates default WEBKIT_VERSION hash from 2317e14... to 863778...
Serialization memory management src/bun.js/bindings/Serialization.cpp	Changes deallocation in Bun__SerializedScriptSlice__free from delete value; to value->deref(); for proper reference-counted lifecycle handling

Possibly related PRs

• Bump WebKit #22957: Modifies the same WEBKIT_VERSION default assignment in cmake/tools/SetupWebKit.cmake
• Disable glibcxx assertions in WebKit release non-asan builds #22647: Updates the default WEBKIT_VERSION value in cmake/tools/SetupWebKit.cmake
• Upgrade WebKit #22499: Changes the default WEBKIT_VERSION hash on the same line in cmake/tools/SetupWebKit.cmake

Pre-merge checks

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	PR description covers main objective and includes code explanation, but verification section is empty.	Complete the 'How did you verify your code works?' section with specific testing details or verification steps performed.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main objective of enabling CHECK_REF_COUNTED_LIFECYCLE in WebKit, which aligns with the changes made.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}