Skip to content

Enable CHECK_REF_COUNTED_LIFECYCLE #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sosukesuzuki merged 1 commit into from
Dec 27, 2025
Merged

Enable CHECK_REF_COUNTED_LIFECYCLE #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions Source/JavaScriptCore/wasm/WasmMemory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,7 @@ class Memory final : public RefCountedAndCanMakeWeakPtr<Memory> {

void registerInstance(JSWebAssemblyInstance&);

// FIXME: Remove this check when CHECK_REF_COUNTED_LIFECYCLE is enabled for Bun
#if USE(BUN_JSC_ADDITIONS)
void checkLifetime() { }
#else
void checkLifetime() { ASSERT(!refCountDebugger().deletionHasBegun()); }
#endif

static constexpr ptrdiff_t offsetOfHandle() { return OBJECT_OFFSETOF(Memory, m_handle); }

Expand Down
5 changes: 1 addition & 4 deletions Source/WTF/wtf/RefCountDebugger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,7 @@

namespace WTF {

// FIXME: Enable CHECK_REF_COUNTED_LIFECYCLE for Bun
#if USE(BUN_JSC_ADDITIONS)
#define CHECK_REF_COUNTED_LIFECYCLE 0
#elif ASSERT_ENABLED || ENABLE(SECURITY_ASSERTIONS)
#if ASSERT_ENABLED || ENABLE(SECURITY_ASSERTIONS)
#define CHECK_REF_COUNTED_LIFECYCLE 1
#else
#define CHECK_REF_COUNTED_LIFECYCLE 0
Expand Down