Skip to content

Conversation

@samsonasik
Copy link

@samsonasik samsonasik commented Jul 2, 2025

Description

@ostrolucky here to handle preload conflict in issue:

Motivation and context

To make work on php 8.3

Screenshot 2025-07-02 at 11 36 45

How has this been tested?

Yes, run composer update && vendor/bin/phpunit on php8.3 env

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

PR checklist

  • I have read the CONTRIBUTING.md document.

@ostrolucky
Copy link
Owner

Thank you! However, it seems this breaks phpstan now? 🤔

@samsonasik
Copy link
Author

samsonasik commented Jul 2, 2025

@ostrolucky in seems in preload.php, it needs initialized:

if (defined('__PHPSTAN_RUNNING__')) {
    return;
}

I will create PR for that.

@smnandre
Copy link

(Got a similar problem.. thank you @samsonasik for your messages on rector, here, and for sharing the solutions!)

"require": {
"php": "^8.1",
"rector/rector": "^1.0 || ^2.1"
"rector/rector": "dev-main#3c07e2ab69c55752e5f143ea99119b475e14ac19"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ostrolucky I temporary use rector/rector:dev-main so it can be checked that it works on this PR

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that it did the trick!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ostrolucky feel free to take care the rest when next rector released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants