-
-
Notifications
You must be signed in to change notification settings - Fork 1
chore!: handle conflict phpunit 12+ conflict preload with rector #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you! However, it seems this breaks phpstan now? 🤔 |
|
@ostrolucky in seems in if (defined('__PHPSTAN_RUNNING__')) {
return;
}I will create PR for that. |
|
(Got a similar problem.. thank you @samsonasik for your messages on rector, here, and for sharing the solutions!) |
| "require": { | ||
| "php": "^8.1", | ||
| "rector/rector": "^1.0 || ^2.1" | ||
| "rector/rector": "dev-main#3c07e2ab69c55752e5f143ea99119b475e14ac19" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ostrolucky I temporary use rector/rector:dev-main so it can be checked that it works on this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that it did the trick!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ostrolucky feel free to take care the rest when next rector released :)
Description
@ostrolucky here to handle preload conflict in issue:
Motivation and context
To make work on php 8.3
How has this been tested?
Yes, run composer update && vendor/bin/phpunit on php8.3 env
Types of changes
PR checklist