Skip to content

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik marked this pull request as draft July 1, 2025 17:40
@samsonasik
Copy link
Member Author

samsonasik commented Jul 1, 2025

Manually testing vendor in laminas-servicemanager-migration, this change cause invalid result:

Time: 00:00.629, Memory: 62.00 MB

There were 3 failures:

1) LaminasTest\ServiceManager\Migration\Rector\Class_\ImplementsFactoryInterfaceToPsrFactoryRector\AutoImportRenameUseTest::test with data set #1 ('/Users/samsonasik/www/laminas...hp.inc')
Failed on fixture file "implements_root_factory_interface.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 namespace LaminasTest\ServiceManager\Migration\Rector\Class_\FixtureAutoImportRenameUse\Fixture;
 
-use Psr\Container\ContainerInterface;
+use Interop\Container\ContainerInterface;
 use Laminas\ServiceManager\Factory\FactoryInterface;
 
 class ServiceFactory
 {
-    public function __invoke(ContainerInterface $container)
+    public function __invoke(\Psr\Container\ContainerInterface $container)

@samsonasik
Copy link
Member Author

@ostrolucky I got it, you need to add:

        "files": [
            "vendor/rector/rector/preload.php"
        ]

under autoload-dev, I created PR to your repository:

@samsonasik samsonasik closed this Jul 2, 2025
@samsonasik samsonasik deleted the modify-autoload branch July 2, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants