Skip to content

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Jul 2, 2025

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba
Copy link
Member

This look a bit hacky. What is the change in PHPUnit 12 that caused this?

@ostrolucky
Copy link

@samsonasik
Copy link
Member Author

I am not sure to be honest, but these 2 lines for too early load is shown here:

even without setup phpunit bootstrap, it will always load vendor/autoload.php too early.

That happen only on phpunit 12+, with php 8.3+, so either it phpunit issue, or php 8.3 changed behaviour.

@samsonasik
Copy link
Member Author

@ostrolucky in seems in rector preload.php, it needs initialized:

if (defined('__PHPSTAN_RUNNING__')) {
    return;
}

I will create PR for that.

@samsonasik
Copy link
Member Author

samsonasik commented Jul 2, 2025

@ostrolucky I created PR:

for that, it seems not ideal, but that's what I can think of right now.

@samsonasik
Copy link
Member Author

@TomasVotruba let's merge this, so it sync with PR:

@samsonasik samsonasik merged commit 71b4e4c into main Jul 23, 2025
8 checks passed
@samsonasik samsonasik deleted the doc-trouble-shoot-preload branch July 23, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants