Closed
Conversation
Member
Author
|
An updated version of #861 |
Member
Author
|
Prep in: #957 |
cgwalters
force-pushed
the
commit-tmpfile
branch
from
ac665f7 to
fa2bef7
Compare
Closed
|
☔ The latest upstream changes (presumably da0791f) made this pull request unmergeable. Please resolve the merge conflicts. |
cgwalters
force-pushed
the
commit-tmpfile
branch
from
cfff862 to
669195f
Compare
There's lots of mechanically replacing `OtTmpFile` with `GLnxTmpfile`; the biggest changes are in the commit path. Symlink commits are now very clearly separated from regular files. Symlinks are `OtCleanupUnlinkat`, and regular files are `GLnxTmpfile`. The commit codepath separates those as `_ostree_repo_commit_path_final()` and `_ostree_repo_commit_tmpf_final()`. A nice aspect of all of this is that they both *consume* the temporary on success. This avoids an extra spurious `unlink()` call. One of the biggest bits of code motion is in `commit_loose_regfile_object()`, which no longer needs to care about symlinks. For the most parth though it's just removing conditionals. Update submodule: libglnx
Member
Author
|
Rebased 🏄♂️ and fixed up commit message. No longer WIP. |
Member
Author
|
(Though for some reason at least here github is failing to rerender this PR update) |
cgwalters
force-pushed
the
commit-tmpfile
branch
from
669195f to
9a6ace0
Compare
jlebon
reviewed
Jun 27, 2017
Member
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
Looks sane. Just one minor nit.
src/libostree/ostree-repo-commit.c
Outdated
| { | ||
| g_assert (_ostree_repo_mode_is_bare (repo_mode)); | ||
| /* Note: This will not be hit for bare-user mode because its converted to a | ||
| regular file and take the branch above */ |
Member
There was a problem hiding this comment.
Nit: this comment needs to be updated.
Member
|
Hmm, we should set up testing against a CentOS kernel. |
Member
|
Let's do #968 first? |
Member
|
☀️ Test successful - status-atomicjenkins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's lots of mechanically replacing
OtTmpFilewithGLnxTmpfile;the biggest changes are in the commit path. Symlink commits are now
very clearly separated from regular files. Symlinks are
OtCleanupUnlinkat,and regular files are
GLnxTmpfile.The commit codepath separates those as
_ostree_repo_commit_path_final()and_ostree_repo_commit_tmpf_final(). A nice aspect of all of this is that theyboth consume the temporary on success. This avoids an extra spurious
unlink()call.One of the biggest bits of code motion is in
commit_loose_regfile_object(),which no longer needs to care about symlinks. For the most parth though it's
just removing conditionals.
Update submodule: libglnx