Update libglnx, port to new GLnxTmpfile#861
Closed
cgwalters wants to merge 2 commits intoostreedev:masterfrom
Closed
Update libglnx, port to new GLnxTmpfile#861cgwalters wants to merge 2 commits intoostreedev:masterfrom
cgwalters wants to merge 2 commits intoostreedev:masterfrom
Conversation
This was a copy-paste-o.
See the rationale in: GNOME/libglnx#46 Basically we should now start unlinking the tmpfile in the non-`O_TMPFILE` case in more places in the code. Parts of the commit path get uglier though, but a refactoring there is a bit overdue; the code is overly complex. Update submodule: libglnx
cgwalters
added a commit
to cgwalters/ostree
that referenced
this pull request
May 16, 2017
I noticed an instance of this while working on ostreedev#861 Which apparently I cargo-culted into the new system generator bits. Let's break this out as a small concise change.
|
☔ The latest upstream changes (presumably 90cd7f7) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
Looks like this needs a rebase. |
Member
Author
|
Yeah...I think given the complexity of the ostree port, my vote is actually to land the libglnx change, update flatpak, and then I'll break out some prep work here and we'll keep libglnx at the current version for a bit while the prep work processes. |
Member
Author
|
Prep in #871 |
Member
Author
|
Obsoleted by #958 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the rationale in: GNOME/libglnx#46
Basically we should now start unlinking the tmpfile in the non-
O_TMPFILEcase in more places in the code.
Parts of the commit path get uglier though, but a refactoring there is
a bit overdue; the code is overly complex.
Update submodule: libglnx