Skip to content

papr: build and test on c7#968

Closed
jlebon wants to merge 2 commits intoostreedev:masterfrom
jlebon:pr/c7-papr
Closed

papr: build and test on c7#968
jlebon wants to merge 2 commits intoostreedev:masterfrom
jlebon:pr/c7-papr

Conversation

@jlebon
Copy link
Copy Markdown
Member

@jlebon jlebon commented Jun 27, 2017

Start testing on CentOS 7 as well to cover kernel differences (e.g.
O_TMPFILE support).

Start testing on CentOS 7 as well to cover kernel differences (e.g.
O_TMPFILE support).
@jlebon jlebon mentioned this pull request Jun 27, 2017
@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Jun 27, 2017

Hmm

cp: cannot stat '/bin/busybox': No such file or directory
1..3
ERROR: tests/test-switchroot.sh - too few tests run (expected 3, got 0)
ERROR: tests/test-switchroot.sh - exited with status 1

Coming from:

	cp /bin/busybox "$1/bin"
	busybox --list | xargs -n1 -I '{}' ln -s busybox "$1/bin/{}"

But I'm confused how that ever worked. Looking at recent tests, this test is skipped because of:

	unshare -m true || \
	    skip "this test needs to set up mount namespaces, rerun as root"

Seems like we should make it conditional on having /bin/busybox?

@cgwalters
Copy link
Copy Markdown
Member

Yes, but there's an issue before that; test-switchroot.sh requires CAP_SYS_ADMIN, which f25-primary doesn't have, but you do have since you're running the container with --privileged.

It looks like we should just skip this test if we don't have busybox, but also try to install it?

Hrm, also this test doesn't quite work installed yet 😦

@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Jun 27, 2017

Right, it's only showing up now because unshare doesn't fail. EPEL doesn't seem to have it unfortunately. :(

It looks like we should just skip this test if we don't have busybox, but also try to install it?

Yup, done above! ⬆️

@cgwalters
Copy link
Copy Markdown
Member

unshare is part of util-linux.

@cgwalters
Copy link
Copy Markdown
Member

@rh-atomic-bot r+ 61a63cd

@rh-atomic-bot
Copy link
Copy Markdown

⌛ Testing commit 61a63cd with merge 79f285d...

rh-atomic-bot pushed a commit that referenced this pull request Jun 27, 2017
Closes: #968
Approved by: cgwalters
@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Jun 27, 2017

Sorry, the "it" in my second sentence was referring to busybox, not unshare (in response to your suggestion to try to install it). I didn't look too hard if we could get it easily from somewhere else.

@rh-atomic-bot
Copy link
Copy Markdown

☀️ Test successful - status-atomicjenkins
Approved by: cgwalters
Pushing 79f285d to master...

@jlebon jlebon deleted the pr/c7-papr branch September 13, 2017 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants