weldr,cloudapi: tweaks around the reporegistry handling#4910
Merged
achilleas-k merged 2 commits intoosbuild:mainfrom Oct 31, 2025
Merged
weldr,cloudapi: tweaks around the reporegistry handling#4910achilleas-k merged 2 commits intoosbuild:mainfrom
achilleas-k merged 2 commits intoosbuild:mainfrom
Conversation
mvo5
requested review from
achilleas-k,
bcl and
croissanne
and removed request for
a team
By doing this we can drop the DistroHasRepos() from images. This is the only API user. If dropping is undesired I think we should change the signature of DistroHasRepos() to become `(bool, error)` (or just error).
The cloudapi depsolve() endpoint is currently not taking tagged repositories into account. Ensure that when an imagetype is specified the repos are parsed again so that any "tagged" repos for specific image types are taken into account as well.
achilleas-k
force-pushed
the
reporegistry-tweaks
branch
from
b125446 to
cb529a4
Compare
Member
|
Clicked rebase. New terraform configs merged in |
lzap
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small tweak that I noticed while working on
osbuild/images#1980
(and osbuild/image-builder-cli#360)
cloudapi: when depsolving specific imagetypes used
ReposByImageTypeName
The cloudapi depsolve() endpoint is currently not taking tagged
repositories into account. Ensure that when an imagetype is
specified the repos are parsed again so that any "tagged" repos
for specific image types are taken into account as well.
weldr: use ReposByArchName() instead of DistroHasRepos()
By doing this we can drop the DistroHasRepos() from images. This
is the only API user.
If dropping is undesired I think we should change the signature
of DistroHasRepos() to become
(bool, error)(or just error).