main: fix missing append of repositories when using --data-dirs
#360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the missing appending of `repositories` when `--data-dirs` is used. It also improves the tests a bit to ensure this won't happen again. Thanks to Achilleas for finding this! This was missing when we did osbuild#128
mvo5
requested review from
achilleas-k,
bcl and
croissanne
and removed request for
a team
achilleas-k
previously approved these changes
Oct 30, 2025
Member
achilleas-k
left a comment
achilleas-k
left a comment
There was a problem hiding this comment.
Tiny nitpick. Fine to handle in a followup.
Thanks!! LGTM
This was referenced Oct 30, 2025
Make it more obvious that data dirs and repo dirs are distinct by renaming them. Thanks to Achilleas for the suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the missing appending of
repositorieswhen--data-dirsis used. It also improves the tests a bit to ensure this won't happen again.Thanks to Achilleas for finding this!
This was missing when we did
#128