Skip to content

weldr,cloudapi: tweaks around the reporegistry handling #4910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
achilleas-k merged 2 commits into from
Oct 31, 2025
Merged

weldr,cloudapi: tweaks around the reporegistry handling #4910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c08eba
weldr: use ReposByArchName() instead of DistroHasRepos()
mvo5 Oct 30, 2025
cb529a4
cloudapi: when depsolving specific imagetypes used ReposByImageTypeName
mvo5 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion internal/cloudapi/v2/depsolve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,12 @@ func (request *DepsolveRequest) Depsolve(df *distrofactory.Factory, rr *reporegi
if err != nil {
return nil, HTTPError(ErrorUnsupportedImageType)
}

// image type may have "tagged" repos that are only available for this
// image type so we need to re-read
repos, err = rr.ReposByImageTypeName(imageType.Arch().Distro().Name(), imageType.Arch().Name(), imageType.Name())
if err != nil {
return nil, HTTPError(ErrorUnsupportedImageType)
}
// use the same seed for all images so we get the same IDs
bigSeed, err := rand.Int(rand.Reader, big.NewInt(math.MaxInt64))
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion internal/weldr/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ func (api *API) validDistros(arch string) []string {
continue
}

_, err := api.repoRegistry.DistroHasRepos(distroName, arch)
_, err := api.repoRegistry.ReposByArchName(distroName, arch, false)
if err == nil {
distros = append(distros, distroName)
} else {
Expand Down
Loading