go.mod: update osbuild/images to v0.95.0 #4448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thozza
reviewed
Oct 31, 2024
achilleas-k
force-pushed
the
deps/images/v0.95.0
branch
2 times, most recently
from
fe48bb7 to
7f38ffb
Compare
Member
Author
|
Bunch of failures here and I suspect I missed a test config that should have the new option enabled. Looking at the journal log from one of the API-module-hotfixes tests, I see that But, if I'm reading the test setup correctly:
🤔 |
Member
Author
Oh, I see... |
achilleas-k
force-pushed
the
deps/images/v0.95.0
branch
from
7f38ffb to
afc2c9b
Compare
achilleas-k
force-pushed
the
deps/images/v0.95.0
branch
from
afc2c9b to
78cf7da
Compare
Member
Author
|
Sorry, missed a couple of more test configs. -_- |
osbuild/images added an error type that's returned when the reporegistry loader doesn't find any repository configurations to load [1]. This lets callers decide whether to stop or continue execution based on whether repository configurations are required. A new top-level configuration option is added for osbuild-composer that makes it possible to start the service without having static rpm repositories configured. This is useful in certain (SaaS) modes where build requests specify their own repository configurations.
If weldr tries to initialise when there are no repositories set and ignore_missing_repos is enabled, return with an error.
thozza
force-pushed
the
deps/images/v0.95.0
branch
from
78cf7da to
02b3c02
Compare
Contributor
|
All green! |
lzap
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small update that only includes one PR from osbuild/images: osbuild/images#946
The second and third commits change the behaviour of osbuild-composer's startup when no repositories are configured.
Weldr (running on-prem) requires local repository configurations, while the API (SaaS) doesn't. However, at the time during startup when reporegistry.LoadAllRepositories() is called, it is still not known whether the Weldr API will be initialised.
Since lack of repository configurations is no longer a stop condition for osbuild-composer's startup, the Weldr API will now return with an error when no repositories are configured during its initialisation.