composer: simplify loading the repositories#4449
Closed
mvo5 wants to merge 1 commit intoosbuild:mainfrom
Closed
Conversation
Move to use `reporegistry.New(repositoryConfigs)` which will do the equivivalent of the existing code and is shorter. With this merged we can unexport `LoadAllRepositories()` and remove `NewFromDistrosRepoConfigs` from the "images" library as this is the only place using them.
thozza
requested changes
Nov 4, 2024
Contributor
Author
|
Closing for now as the new code make this no longer feasible (i.e. just calling New() like before is no longer an option) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move to use
reporegistry.New(repositoryConfigs)which will do the equivivalent of the existing code and is shorter.With this merged we can unexport
LoadAllRepositories()and removeNewFromDistrosRepoConfigsfrom the "images" library as this is the only place using them.