reporegistry: add NoReposLoadedError and use it #946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `NoReposLoadedError` custom error type for the case when any function that is supposed to load repository configs, does not load any. Use it in all functions that are directly loading repositories from configuration files. I considered `NoReposError` name, but that could be later added for functions such as `RepoRegistry.ReposBy...()`, in case there are no repositories in the RepoRegistry for the given image type / arch. Signed-off-by: Tomáš Hozza <[email protected]>
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
achilleas-k
added a commit
to achilleas-k/osbuild-composer
that referenced
this pull request
Oct 30, 2024
osbuild/images added an error type that's returned when the reporegistry loader doesn't find any repository configurations to load [1]. This lets callers decide whether to stop or continue execution based on whether repository configurations are required. Weldr (running on-prem) requires local repository configurations, while the API (SaaS) doesn't. However, at the time during startup when reporegistry.LoadAllRepositories() is called, it is still not known whether the Weldr API will be initialised. Log the error message as an info message when it is detected but continue execution. [1] osbuild/images#946
achilleas-k
added a commit
to achilleas-k/osbuild-composer
that referenced
this pull request
Oct 30, 2024
osbuild/images added an error type that's returned when the reporegistry loader doesn't find any repository configurations to load [1]. This lets callers decide whether to stop or continue execution based on whether repository configurations are required. Weldr (running on-prem) requires local repository configurations, while the API (SaaS) doesn't. However, at the time during startup when reporegistry.LoadAllRepositories() is called, it is still not known whether the Weldr API will be initialised. Log the error message as an info message when it is detected but continue execution. [1] osbuild/images#946
achilleas-k
added a commit
to achilleas-k/osbuild-composer
that referenced
this pull request
Oct 31, 2024
osbuild/images added an error type that's returned when the reporegistry loader doesn't find any repository configurations to load [1]. This lets callers decide whether to stop or continue execution based on whether repository configurations are required. Weldr (running on-prem) requires local repository configurations, while the API (SaaS) doesn't. However, at the time during startup when reporegistry.LoadAllRepositories() is called, it is still not known whether the Weldr API will be initialised. Log the error message as an info message when it is detected but continue execution. [1] osbuild/images#946
achilleas-k
added a commit
to achilleas-k/osbuild-composer
that referenced
this pull request
Oct 31, 2024
osbuild/images added an error type that's returned when the reporegistry loader doesn't find any repository configurations to load [1]. This lets callers decide whether to stop or continue execution based on whether repository configurations are required. Weldr (running on-prem) requires local repository configurations, while the API (SaaS) doesn't. However, at the time during startup when reporegistry.LoadAllRepositories() is called, it is still not known whether the Weldr API will be initialised. Log the error message as an info message when it is detected but continue execution. [1] osbuild/images#946
mvo5
added a commit
to mvo5/osbuild-composer
that referenced
this pull request
Jan 29, 2025
This commit changes cmd/composer to use the `reporegistry.New` call again. This is a preparation for osbuild/images#1179 And undoes parts of osbuild#4378 but that is no longer necessary because in osbuild/images#946 the error is now passed on from `reporegistry.New()` in the same way as from `LoadRepositories()`.
thozza
pushed a commit
to osbuild/osbuild-composer
that referenced
this pull request
Jan 29, 2025
This commit changes cmd/composer to use the `reporegistry.New` call again. This is a preparation for osbuild/images#1179 And undoes parts of #4378 but that is no longer necessary because in osbuild/images#946 the error is now passed on from `reporegistry.New()` in the same way as from `LoadRepositories()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
NoReposLoadedErrorcustom error type for the case when any function that is supposed to load repository configs, does not load any. Use it in all functions that are directly loading repositories from configuration files.I considered
NoReposErrorname, but that could be later added for functions such asRepoRegistry.ReposBy...(), in case there are no repositories in the RepoRegistry for the given image type / arch.This is a follow-up to osbuild/osbuild-composer#4378