image-info: update for new "partition" option in mounts.Mount #3883
Conversation
mvo5
force-pushed
the
update-image-info-for-pr-1501
branch
from
4cd356b
to
5140877
Compare
mvo5
force-pushed
the
update-image-info-for-pr-1501
branch
from
5140877
to
5dc58eb
Compare
There was a problem hiding this comment.
Thanks. Found just one small nitpick. LGTM otherwise 👍
Can you please fix also https://github.com/osbuild/manifest-db/blob/main/tools/image-info ? 🙇♂️
Thank you! On this side a similar fix was added in osbuild/manifest-db#101 - TBH I'm not too happy with the mounts.Mount() api right now and will look into this again (hopefully) as this workaround is not super nice. |
In the osbuild PR#1501 [0] a new paramter "partition" for mounts.Mount() was added. This commit updates the code that it deals cleanly with the new and the old API for `mount.Mount`. [0] osbuild/osbuild#1501
mvo5
force-pushed
the
update-image-info-for-pr-1501
branch
from
5dc58eb
to
e9715b1
Compare
Oh nice. I looked in the repo, but didn't consider an option that the fix was already merged there... Thanks 👍 |
In the osbuild PR#1501 [0] a new paramter "partition" for
mounts.Mount() was added.
This commit updates the code that it deals cleanly with the new
and the old API for
mount.Mount.[0] osbuild/osbuild#1501