Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test runners to Fedora 39 #3820

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Update test runners to Fedora 39 #3820

merged 6 commits into from
Jan 10, 2024

Conversation

atodorov
Copy link
Contributor

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as

achilleas-k
achilleas-k previously approved these changes Nov 27, 2023
View reviewed changes
jrusz
jrusz previously requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@jrusz jrusz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an entry for Fedora-39 in Schutzfile as well please?

schutzbot
schutzbot reviewed Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 8e49f8e with the main merge-base 4050aa9). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/5625942156/artifacts/browse

@atodorov atodorov marked this pull request as draft November 28, 2023 09:26
@atodorov atodorov marked this pull request as ready for review November 28, 2023 14:54
@atodorov atodorov changed the title Update test runners to Fedora 39 WIP: Update test runners to Fedora 39 Nov 28, 2023
@atodorov atodorov force-pushed the test_with_fedora39 branch 11 times, most recently from 27e0a5a to 8eb6f8a Compare December 5, 2023 09:57
@atodorov atodorov mentioned this pull request Dec 5, 2023
Merged
@atodorov atodorov force-pushed the test_with_fedora39 branch 5 times, most recently from d060319 to 92fedfe Compare December 7, 2023 15:00
@atodorov atodorov enabled auto-merge (rebase) December 7, 2023 16:52
@atodorov atodorov changed the title WIP: Update test runners to Fedora 39 Update test runners to Fedora 39 Dec 7, 2023
achilleas-k
achilleas-k previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

atodorov added a commit to atodorov/osbuild-composer that referenced this pull request Jan 9, 2024
@atodorov
Skip filesystem.sh test job on Fedora-39
fd07b38 
looks like there is a kernel bug and the patch is 6+ months old:
osbuild#3820 (comment)
@atodorov atodorov force-pushed the test_with_fedora39 branch 2 times, most recently from fd07b38 to f1cd1e4 Compare January 9, 2024 08:16
atodorov added a commit to atodorov/osbuild-composer that referenced this pull request Jan 9, 2024
@atodorov
Skip filesystem.sh test job on Fedora-39
f1cd1e4 
looks like there is a kernel bug and the patch is 6+ months old:
osbuild#3820 (comment)
mvo5
mvo5 reviewed Jan 9, 2024
View reviewed changes
.gitlab-ci.yml Show resolved Hide resolved
atodorov added a commit to atodorov/osbuild-composer that referenced this pull request Jan 9, 2024
@atodorov
Skip filesystem.sh test job on Fedora-39
9babebb 
looks like there is a kernel bug and the patch is 6+ months old:
osbuild#3820 (comment)
@atodorov atodorov requested a review from mvo5 January 9, 2024 11:22
ondrejbudai
ondrejbudai approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mvo5
mvo5 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a difficult one, thank you for your patience!

@achilleas-k
Copy link
Member

This was a difficult one, thank you for your patience!

Thank you SO MUCH for all the effort you put into this! ❤️

@achilleas-k achilleas-k dismissed jrusz’s stale review January 9, 2024 16:51

Schutzfile entry added

@achilleas-k
Copy link
Member

Comments addressed.
RHEL 9.4 nightly failures are being addressed in #3883.

We can admin merge if we're in a real hurry to get this in, but it looks like the other PR should be passing soon too so maybe it can wait.

@thozza thozza enabled auto-merge (rebase) January 10, 2024 08:40
@thozza thozza merged commit 22febe2 into osbuild:main Jan 10, 2024
71 checks passed
@atodorov atodorov deleted the test_with_fedora39 branch January 10, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schutzbot schutzbot schutzbot left review comments

@ondrejbudai ondrejbudai ondrejbudai approved these changes

@mvo5 mvo5 mvo5 approved these changes

@achilleas-k achilleas-k achilleas-k approved these changes

@thozza thozza thozza approved these changes

@jrusz jrusz Awaiting requested review from jrusz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@atodorov @achilleas-k @mvo5 @henrywang @ondrejbudai @thozza @jrusz @schutzbot