Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/image-info: Update Mount() signature. #101

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

dustymabe
Copy link
Contributor

This is needed for when osbuild/osbuild#1501 merges. That PR adds the ability to mount partition device from a defined source rather than the source itself directly and the partition option to the function was added to allow requesting this behavior.

@dustymabe
Copy link
Contributor Author

CI failed here I think because it needs osbuild/osbuild#1501 to merge first. Unfortunately we're going to have to merge one of this PR or that one without full CI passing I think because the changes are coupled together.

Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, one suggestion inline how to avoid the CI failure (a bit heavy handed maybe but we can just remove it after and it's a nice feeling to have green CI :)

tools/image-info Outdated Show resolved Hide resolved
This is needed for when osbuild/osbuild#1501
merges. That PR adds the ability to mount partition device from
a defined source rather than the source itself directly and the
partition option to the function was added to allow requesting this
behavior.

Co-authored-by: Michael Vogt <[email protected]>
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thank you!

@dustymabe dustymabe enabled auto-merge (rebase) December 21, 2023 17:01
@dustymabe dustymabe merged commit 7fd306c into osbuild:main Dec 21, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants