MGMT-23507: Update submodules to latest main - #55
Conversation
…o latest main Updates submodule refs to include SecurityGroup provisioning, subnet deletion state propagation, networking retry backoff, organizations API, Host/HostPool removal, and other recent changes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@eranco74: This pull request references MGMT-23507 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@eranco74: This pull request references MGMT-23507 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@eranco74: This pull request references MGMT-23507 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThis pull request updates two submodule references. The Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
base/osac-operator (1)
1-1: Ensure comprehensive testing coverage for 52 commits across two submodules.This PR updates osac-operator (29 commits) and osac-fulfillment-service (23 commits), introducing multiple significant features and changes:
- SecurityGroup provisioning support
- Subnet deletion state propagation
- Networking retry with exponential backoff
- Organizations API
- Host/HostPool removal
- Lease type additions
- Leader election and database metrics
Given the scope, verify that the test plan covers all major features and potential integration points between the updated submodules.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@base/osac-operator` at line 1, The PR touches many cross-cutting features and needs comprehensive tests: add unit tests for SecurityGroup provisioning (e.g., SecurityGroupProvisioner) and subnet state propagation (e.g., SubnetService) including success/failure and state transitions; add unit+integration tests for networking retry/backoff logic (e.g., NetworkingClient.retryWithBackoff or exponentialBackoff) that assert retries, delays and jitter behavior and that transient errors are retried while fatal errors abort; add controller/service tests for the Organizations API (e.g., OrganizationsController/OrganizationsService) covering CRUD, validation and auth cases; add tests for Host and HostPool removal flows (e.g., HostService/HostPoolManager) ensuring related resources are cleaned and edge cases handled; add tests for new Lease type handling (e.g., LeaseType enum consumer code) including serialization/deserialization and business logic that branches on lease type; add leader election tests (e.g., LeaderElector) to simulate leadership changes and ensure only leader executes critical work; add tests for DB metrics emission (e.g., DBMetricsCollector) validating metrics values and tagging; and add cross-module integration/system tests that exercise interactions between osac-operator and osac-fulfillment-service for provisioning, deletion propagation and org workflows, using mocks for external systems, deterministic time control for backoff tests, and CI flaky-test mitigation (retries/timeouts). Ensure test suites cover both happy and failure paths and add appropriate test files and CI job updates to run them for both submodules.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@base/osac-operator`:
- Line 1: Update the JIRA issue MGMT-23507 to include the target version
"4.22.0" for the target branch: open the JIRA ticket MGMT-23507 and set its
Target Version (or Fix Version/s) field to "4.22.0", save the change, and ensure
any related metadata (components/labels) required by CI for release tracking are
present so the bot no longer flags the missing target version.
---
Nitpick comments:
In `@base/osac-operator`:
- Line 1: The PR touches many cross-cutting features and needs comprehensive
tests: add unit tests for SecurityGroup provisioning (e.g.,
SecurityGroupProvisioner) and subnet state propagation (e.g., SubnetService)
including success/failure and state transitions; add unit+integration tests for
networking retry/backoff logic (e.g., NetworkingClient.retryWithBackoff or
exponentialBackoff) that assert retries, delays and jitter behavior and that
transient errors are retried while fatal errors abort; add controller/service
tests for the Organizations API (e.g.,
OrganizationsController/OrganizationsService) covering CRUD, validation and auth
cases; add tests for Host and HostPool removal flows (e.g.,
HostService/HostPoolManager) ensuring related resources are cleaned and edge
cases handled; add tests for new Lease type handling (e.g., LeaseType enum
consumer code) including serialization/deserialization and business logic that
branches on lease type; add leader election tests (e.g., LeaderElector) to
simulate leadership changes and ensure only leader executes critical work; add
tests for DB metrics emission (e.g., DBMetricsCollector) validating metrics
values and tagging; and add cross-module integration/system tests that exercise
interactions between osac-operator and osac-fulfillment-service for
provisioning, deletion propagation and org workflows, using mocks for external
systems, deterministic time control for backoff tests, and CI flaky-test
mitigation (retries/timeouts). Ensure test suites cover both happy and failure
paths and add appropriate test files and CI job updates to run them for both
submodules.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 639f24c2-7e00-46be-a24f-f47c9c9a9f95
📒 Files selected for processing (2)
base/osac-fulfillment-servicebase/osac-operator
| @@ -1 +1 @@ | |||
| Subproject commit 6df2a1ed6882690c784645f0043dc1881ffc4557 | |||
| Subproject commit f81b015385154c341d5c5af5734722b3935c1127 | |||
There was a problem hiding this comment.
Address JIRA target version warning.
The CI bot flagged that the referenced JIRA issue (MGMT-23507) is missing the expected target version "4.22.0" for the target branch. Please update the JIRA issue to include the correct target version to ensure proper release tracking.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@base/osac-operator` at line 1, Update the JIRA issue MGMT-23507 to include
the target version "4.22.0" for the target branch: open the JIRA ticket
MGMT-23507 and set its Target Version (or Fix Version/s) field to "4.22.0", save
the change, and ensure any related metadata (components/labels) required by CI
for release tracking are present so the bot no longer flags the missing target
version.
|
@eranco74: This pull request references MGMT-23507 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tzumainn can I bump theulfillment-service and osac-operator to latest? |
tzumainn
left a comment
tzumainn
left a comment
There was a problem hiding this comment.
Oh yeah - sorry, I should have considered that!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eranco74, tzumainn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Summary
fulfillment-servicesubmodule from5587c36to80e77b6(23 new commits)osac-operatorsubmodule fromf4f99a7tof81b015(29 new commits)osac-aapalready at latest main — no change neededNotable changes included
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit