This repository was archived by the owner on Sep 9, 2026. It is now read-only.
Remove HostPool and Host resource from osac-operator - #174
Merged
openshift-merge-bot[bot] merged 1 commit intoApr 6, 2026
Merged
Conversation
tzumainn
requested review from
adriengentil
and removed request for
akshaynadkarni and
tzvatot
April 3, 2026 20:49
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 4 minutes and 36 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (17)
📒 Files selected for processing (32)
📝 WalkthroughWalkthroughThis PR removes the HostPool custom resource and all associated code from the OSAC operator, including API type definitions, controllers, RBAC rules, CRD manifests, configuration, tests, and provisioning handlers across multiple packages. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 92: Replace the ambiguous phrase "Cluster controller" in the README with
the consistent term "ClusterOrder controller": locate the text that currently
reads "Cluster controller" (the literal string) and change it to "ClusterOrder
controller", and scan nearby README occurrences and flag descriptions to ensure
all mentions use "ClusterOrder controller" for terminology consistency across
the doc.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 98bad6dc-52be-486c-909a-bb8edf00ac86
⛔ Files ignored due to path filters (17)
internal/api/osac/private/v1/event_type.pb.gois excluded by!**/*.pb.gointernal/api/osac/private/v1/event_type_protoopaque.pb.gois excluded by!**/*.pb.gointernal/api/osac/private/v1/host_pool_type.pb.gois excluded by!**/*.pb.gointernal/api/osac/private/v1/host_pool_type_protoopaque.pb.gois excluded by!**/*.pb.gointernal/api/osac/private/v1/host_pools_service.pb.gois excluded by!**/*.pb.gointernal/api/osac/private/v1/host_pools_service_grpc.pb.gois excluded by!**/*.pb.gointernal/api/osac/private/v1/host_pools_service_protoopaque.pb.gois excluded by!**/*.pb.gointernal/api/osac/private/v1/host_type.pb.gois excluded by!**/*.pb.gointernal/api/osac/private/v1/host_type_protoopaque.pb.gois excluded by!**/*.pb.gointernal/api/osac/private/v1/hosts_service.pb.gois excluded by!**/*.pb.gointernal/api/osac/private/v1/hosts_service_grpc.pb.gois excluded by!**/*.pb.gointernal/api/osac/private/v1/hosts_service_protoopaque.pb.gois excluded by!**/*.pb.gointernal/api/osac/private/v1/organization_type.pb.gois excluded by!**/*.pb.gointernal/api/osac/private/v1/organization_type_protoopaque.pb.gois excluded by!**/*.pb.gointernal/api/osac/private/v1/organizations_service.pb.gois excluded by!**/*.pb.gointernal/api/osac/private/v1/organizations_service_grpc.pb.gois excluded by!**/*.pb.gointernal/api/osac/private/v1/organizations_service_protoopaque.pb.gois excluded by!**/*.pb.go
📒 Files selected for processing (32)
.golangci.ymlPROJECTREADME.mdapi/v1alpha1/hostpool_conditions.goapi/v1alpha1/hostpool_hostpoolreference.goapi/v1alpha1/hostpool_types.goapi/v1alpha1/zz_generated.deepcopy.gobuf.gen.yamlcmd/main.goconfig/crd/bases/osac.openshift.io_hostpools.yamlconfig/crd/kustomization.yamlconfig/manager/manager.yamlconfig/rbac/hostpool_admin_role.yamlconfig/rbac/hostpool_editor_role.yamlconfig/rbac/hostpool_viewer_role.yamlconfig/rbac/kustomization.yamlconfig/rbac/role.yamlconfig/samples/kustomization.yamlconfig/samples/osac-config-secret.yamlconfig/samples/osac_v1alpha1_hostpool.yamlinternal/controller/hostpool_controller.gointernal/controller/hostpool_controller_test.gointernal/controller/hostpool_feedback_controller.gointernal/controller/hostpool_integration_test.gointernal/controller/hostpool_names.gointernal/controller/hostpool_resources.gointernal/provisioning/aap_provider.gointernal/provisioning/aap_provider_test.gointernal/provisioning/eda_provider.gointernal/provisioning/eda_provider_test.gointernal/provisioning/provision_lifecycle.gointernal/provisioning/provision_lifecycle_test.go
💤 Files with no reviewable changes (27)
- .golangci.yml
- config/crd/kustomization.yaml
- config/samples/kustomization.yaml
- config/rbac/kustomization.yaml
- config/rbac/hostpool_admin_role.yaml
- internal/provisioning/provision_lifecycle_test.go
- internal/provisioning/provision_lifecycle.go
- internal/provisioning/aap_provider.go
- config/rbac/hostpool_viewer_role.yaml
- PROJECT
- internal/provisioning/aap_provider_test.go
- config/manager/manager.yaml
- internal/provisioning/eda_provider.go
- internal/controller/hostpool_names.go
- api/v1alpha1/hostpool_conditions.go
- config/samples/osac_v1alpha1_hostpool.yaml
- config/rbac/hostpool_editor_role.yaml
- internal/controller/hostpool_controller_test.go
- internal/controller/hostpool_integration_test.go
- api/v1alpha1/hostpool_hostpoolreference.go
- internal/controller/hostpool_resources.go
- config/rbac/role.yaml
- config/crd/bases/osac.openshift.io_hostpools.yaml
- api/v1alpha1/zz_generated.deepcopy.go
- api/v1alpha1/hostpool_types.go
- internal/controller/hostpool_feedback_controller.go
- internal/controller/hostpool_controller.go
These resources will be replaced by new resources specified in the updated bare metal fulfillment proposal. - Delete HostPool CRD and sample resource - Remove HostPool API types from api/v1alpha1/ - Remove HostPool controllers (6 files) - Remove generated proto files for Host, HostPool, and HostClass - Clean up RBAC roles and permissions - Update kustomization files - Remove configuration artifacts and environment variables - Update documentation (README, golangci config) - Remove unused HostPoolAAPFinalizer constant Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
tzumainn
force-pushed
the
remove-host-hostpool
branch
from
April 3, 2026 20:55
6104b77 to
43a0e6f
Compare
larsks
approved these changes
Apr 6, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: larsks, tzumainn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These resources will be replaced by new resources specified in the updated bare metal fulfillment proposal.
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com
Summary by CodeRabbit
Removals
Documentation
Chores