Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Update osac-operator submodule to latest main - #352

Merged
eliorerz merged 1 commit into
osac-project:mainfrom
eliorerz:fix-osac-operator-submodule
Jun 26, 2026
Merged

eliorerz merged 1 commit into
osac-project:mainfrom
eliorerz:fix-osac-operator-submodule

Conversation

@eliorerz

@eliorerz eliorerz commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update osac-operator submodule from 08991cc to 7e4222b (latest upstream/main)
  • Sync image tags via scripts/sync-image-tags.sh --fix

Problem

The previous submodule commit (08991cc) has no published container image on ghcr.io, causing ImagePullBackOff for osac-operator and osac-operator-console-proxy pods in CI deployments.

Test plan

  • CI image tag check passes
  • E2E tests deploy without ImagePullBackOff

Summary by CodeRabbit

  • Chores
    • Updated the operator image revision used by the deployment and CI environments to a newer build.
    • Applied the same image update across the base configuration and CI values for consistency.

Update osac-operator submodule to latest main (7e4222b) which has a
published container image. The previous submodule commit (08991cc) had
no published image, causing ImagePullBackOff in CI deployments.
@openshift-ci
openshift-ci Bot requested review from adriengentil and danmanor June 25, 2026 22:26
@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliorerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 40e97cbc-05c8-46a7-b5e0-98824dea224d

📥 Commits

Reviewing files that changed from the base of the PR and between 768174e and d90ad11.

📒 Files selected for processing (4)
  • base/kustomization.yaml
  • base/osac-operator
  • values/caas-ci/values.yaml
  • values/vmaas-ci/values.yaml

Walkthrough

This PR updates the pinned osac-operator revision in the base configuration and changes the operator image tag in the CaaS and VMaaS CI values to the same new SHA.

Changes

OSAC operator version bump

Layer / File(s) Summary
Base operator pin
base/osac-operator, base/kustomization.yaml
The base submodule pointer and kustomize image override move from sha-08991cc to sha-7e4222b.
CI image tags
values/caas-ci/values.yaml, values/vmaas-ci/values.yaml
Both CI values files update operator.image.tag to sha-7e4222b.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

  • eranco74
  • akshaynadkarni
  • omer-vishlitzky

Poem

A tiny SHA took a quiet stride,
through base and CI, it gentlyाइड?
The pins now match in a tidy line,
and operator winds all hum in time. ✨

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: updating the osac-operator submodule to a newer upstream commit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed PR only updates image tags/submodule pointers; no API keys, passwords, private keys, embedded creds, or new secret-like literals were introduced.
No-Weak-Crypto ✅ Passed Only image tags and a submodule pointer changed; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons were introduced.
No-Injection-Vectors ✅ Passed Only static image/tag metadata and a submodule gitlink changed; no eval, shell=True, yaml.load, os.system, or user-controlled interpolation was introduced.
Container-Privileges ✅ Passed Only image tags and a submodule pointer changed; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings were introduced.
No-Sensitive-Data-In-Logs ✅ Passed The PR only updates image tags and a submodule ref; I found no new logging or sensitive-data output in the touched files.
Ai-Attribution ✅ Passed No AI-tool usage is mentioned in the PR or commit message, and no Assisted-by/Generated-by/Co-Authored-By AI trailers were found.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eliorerz eliorerz added the lgtm label Jun 25, 2026
@eliorerz
eliorerz merged commit 9be1b5c into osac-project:main Jun 26, 2026
7 of 8 checks passed
@eliorerz
eliorerz deleted the fix-osac-operator-submodule branch June 26, 2026 00:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant