Conversation
Update osac-operator from c4ee968 to 75f48c7 (origin/main) to pick up the ExternalIP CRD types added in OSAC-1442 (PR #318). Without this bump, the operator binary references ExternalIP, ExternalIPAttachment, and ExternalIPPool CRDs that the chart does not install, causing CrashLoopBackOff. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WalkthroughThis PR updates the ChangesSubmodule Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error, 1 warning)
✅ Passed checks (9 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Update image tags from sha-c4ee968 to sha-75f48c7 in base/kustomization.yaml, values/caas-ci/values.yaml, and values/vmaas-ci/values.yaml to match the updated submodule. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@base/osac-operator`:
- Line 1: The osac-operator image reference is out of sync between the pinned
tag and the updated base/osac-operator revision. Update the image tag used by
the kustomize configuration so ghcr.io/osac-project/osac-operator matches the
new base/osac-operator commit hash 75f48c7a24d5ba9c224b619daf87b8055a78b8a5, and
ensure the kustomization points to the same version.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 129331e0-54d4-4c43-921c-aa7dbcf56d54
📒 Files selected for processing (1)
base/osac-operator
|
/hold |
|
@danmanor: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Summary
base/osac-operatorsubmodule fromc4ee968to75f48c7(latestmain)ExternalIP,ExternalIPAttachment, andExternalIPPoolCRD types and chart templatesno matches for kind "ExternalIP"because the CRDs are not installed by the Helm chart🤖 Generated with Claude Code
Summary by CodeRabbit