Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

NO-ISSUE: Bump osac-operator submodule to include ExternalIP CRDs - #377

Closed
danmanor wants to merge 2 commits into
mainfrom
bump/osac-operator-externalip-crds
Closed

danmanor wants to merge 2 commits into
mainfrom
bump/osac-operator-externalip-crds

Conversation

@danmanor

@danmanor danmanor commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated a bundled component to a newer version.

Update osac-operator from c4ee968 to 75f48c7 (origin/main) to pick up
the ExternalIP CRD types added in OSAC-1442 (PR #318). Without this
bump, the operator binary references ExternalIP, ExternalIPAttachment,
and ExternalIPPool CRDs that the chart does not install, causing
CrashLoopBackOff.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Jul 1, 2026
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

This PR updates the base/osac-operator Git submodule pointer from one commit hash to a newer one. No other code, configuration, or logic changes are included.

Changes

Submodule Update

Layer / File(s) Summary
Bump osac-operator submodule pointer
base/osac-operator
Advances the pinned submodule commit hash to a newer revision, with no other changes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: jira/valid-reference

Suggested reviewers: adriengentil, akshaynadkarni, omer-vishlitzky


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
Container-Privileges ❌ Error base/osac-aap/.devcontainer/*.json runs as root and adds SYS_ADMIN, which is a privileged container config without justification. Remove the root/SYS_ADMIN devcontainer settings or document why they’re required for local dev only. The K8s manifests themselves look hardened.
Ai-Attribution ⚠️ Warning PR/commit mention Claude Code, but the commit uses Co-Authored-By instead of required Assisted-by/Generated-by. Replace the AI co-author line with an Assisted-by or Generated-by trailer per policy.
✅ Passed checks (9 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed PASS: The PR only updates submodule gitlink commits; no text files or secret-like literals are added in the diff.
No-Weak-Crypto ✅ Passed The PR only bumps a submodule pointer; scans of base/osac-operator found no MD5/SHA1/DES/RC4/ECB/custom-crypto or non-constant-time secret compares.
No-Injection-Vectors ✅ Passed The PR only bumps a submodule gitlink; I found no SQL/shell/eval/yaml-load/innerHTML sinks in the touched top-level files or related operator files.
No-Sensitive-Data-In-Logs ✅ Passed Only submodule pointer bumps; inspected updated submodule files and found no log statements exposing secrets/PII. Token strings are env-var/config refs, not logs.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the main change: bumping the osac-operator submodule to include ExternalIP CRDs.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump/osac-operator-externalip-crds

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Update image tags from sha-c4ee968 to sha-75f48c7 in
base/kustomization.yaml, values/caas-ci/values.yaml, and
values/vmaas-ci/values.yaml to match the updated submodule.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@base/osac-operator`:
- Line 1: The osac-operator image reference is out of sync between the pinned
tag and the updated base/osac-operator revision. Update the image tag used by
the kustomize configuration so ghcr.io/osac-project/osac-operator matches the
new base/osac-operator commit hash 75f48c7a24d5ba9c224b619daf87b8055a78b8a5, and
ensure the kustomization points to the same version.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 129331e0-54d4-4c43-921c-aa7dbcf56d54

📥 Commits

Reviewing files that changed from the base of the PR and between 097a25d and eea3cbf.

📒 Files selected for processing (1)
  • base/osac-operator

Comment thread base/osac-operator
@danmanor

danmanor commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

/hold

@danmanor danmanor changed the title Bump osac-operator submodule to include ExternalIP CRDs NO-ISSUE: Bump osac-operator submodule to include ExternalIP CRDs Jul 1, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@danmanor: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
  • Updated a bundled component to a newer version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danmanor danmanor closed this Jul 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants