generate csv: support validating and mutating webhooks #2729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
kind/feature
estroz
force-pushed
the
feature/csv-webhooks
branch
2 times, most recently
from
6cf7672 to
498c6fc
Compare
openshift-ci-robot
added
the
needs-rebase
estroz
force-pushed
the
feature/csv-webhooks
branch
from
498c6fc to
570a6f2
Compare
openshift-ci-robot
removed
the
needs-rebase
estroz
force-pushed
the
feature/csv-webhooks
branch
from
570a6f2 to
bcbc4c9
Compare
Member
Author
|
This PR is broken because the commit used to pin OLM does not have k8s 1.17 deps yet. Waiting for that PR to be updated. Edit: PR updated. |
estroz
force-pushed
the
feature/csv-webhooks
branch
from
bcbc4c9 to
ffd8d59
Compare
estroz
changed the title
estroz
force-pushed
the
feature/csv-webhooks
branch
3 times, most recently
from
d90e577 to
d7c1ccf
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
estroz
force-pushed
the
feature/csv-webhooks
branch
from
d7c1ccf to
5828c59
Compare
Member
Author
|
Webhooks PR has been merged, this is ready for review. |
Contributor
|
hi @estroz, Compilation errors have been faced. See: https://travis-ci.org/github/operator-framework/operator-sdk/jobs/676083461#L911 |
estroz
force-pushed
the
feature/csv-webhooks
branch
from
5828c59 to
d67d147
Compare
Member
Author
|
@camilamacedo86 fixed. |
estroz
force-pushed
the
feature/csv-webhooks
branch
from
d67d147 to
3327873
Compare
camilamacedo86
approved these changes
Apr 29, 2020
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Shows that it is just missing a rebase and few nits as for example changelog/fragments. Could you please add it before merge?
estroz
force-pushed
the
feature/csv-webhooks
branch
from
3327873 to
8d58fb1
Compare
|
New changes are detected. LGTM label has been removed. |
estroz
force-pushed
the
feature/csv-webhooks
branch
from
8d58fb1 to
96b42be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
generate csvadds validating and mutation webhooks to a CSV by reading their config manifests from a deploy dir.Motivation for the change: OLM will support generating admission webhooks for operators soon. The CSV generator should support adding them to new and existing CSV's.
Contains some changes that are nice-to-have from #2511 and necessary changes from #2730Blocked by operator-framework/operator-lifecycle-manager#1436/kind feature