generate csv: refactor CSV updaters to extend to webhooks #2730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/hold waiting to rebase on top of #2511 |
openshift-ci-robot
added
the
do-not-merge/hold
estroz
force-pushed
the
refactor/csv-updaters
branch
2 times, most recently
from
4fb4e60 to
2189d1f
Compare
Member
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
Hi @estroz,
It is not passing in the tests. So, I think we need to fix it first.
estroz
force-pushed
the
refactor/csv-updaters
branch
2 times, most recently
from
16c6beb to
41489cd
Compare
jmccormick2001
approved these changes
Apr 1, 2020
collect all relevant manifests before making decisions like what to filter. This should make the updater extensible in situations where a deep update graph is needed before updates are applied to a CSV internal/scaffold/olm-catalog: refactor CSV updaters, update test data
estroz
force-pushed
the
refactor/csv-updaters
branch
from
41489cd to
dfe6c0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
data
Motivation for the change: CSV Updaters (internal/generate/olm-catalog/csv_updaters.go) have been refactored to be easier to reason about and collect all relevant manifests before making decisions like what to filter. This should make the updater extensible in situations where a deep update graph needs construction before updates are applied to a CSV.
Relates to webhooks support in #2729