Skip to content

WIP: Webhook Admissions #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
awgreene wants to merge 1 commit into from
Closed

WIP: Webhook Admissions #1102

awgreene wants to merge 1 commit into from

Conversation

@awgreene
Copy link
Member

@awgreene awgreene commented Oct 31, 2019

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 31, 2019
ecordell
ecordell reviewed Oct 31, 2019
View reviewed changes
ecordell
ecordell reviewed Oct 31, 2019
View reviewed changes
@awgreene awgreene force-pushed the webhooks branch 7 times, most recently from cc465e6 to e4ad74e Compare November 1, 2019 14:37
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 1, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 1, 2019
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 1, 2019
@awgreene awgreene force-pushed the webhooks branch 2 times, most recently from f1470e4 to c173ab9 Compare November 1, 2019 18:23
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 1, 2019
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 1, 2019

@awgreene: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm c6e6565 link /test e2e-aws-console-olm
ci/prow/e2e-aws-olm c6e6565 link /test e2e-aws-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@awgreene awgreene mentioned this pull request Feb 20, 2020
Closed
5 tasks
@stale
Copy link

stale bot commented Feb 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 26, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2020
@stale stale bot removed the wontfix label Feb 26, 2020
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 26, 2020

@awgreene: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 20, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: awgreene, ravikantcool2019
To complete the pull request process, please assign ecordell
You can assign the PR to them by writing /assign @ecordell in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@njhale njhale mentioned this pull request Mar 24, 2020
Closed
@estroz estroz mentioned this pull request Mar 27, 2020
Merged
@ecordell
Copy link
Member

ecordell commented Apr 10, 2020

closing in favor of #1436

@ecordell ecordell closed this Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ecordell ecordell ecordell left review comments

@njhale njhale Awaiting requested review from njhale

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@awgreene @openshift-ci-robot @ecordell