OCPBUGS-60060: (fix) Update the operator-ibm-cloud-managed with the same configuration applied to operator manually by camilamacedo86 · Pull Request #649 · operator-framework/operator-marketplace

camilamacedo86 · 2025-07-24T10:56:02Z

Description of the change:
The manifest for the IBM pod is outdated and has not fixes done since our make manifest is broken and has not been used to validate the changes in the CI

The following fix were applied to the IBM pod

Motivation for the change:

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /docs
Commit messages sensible and descriptive

openshift-ci · 2025-07-24T10:56:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

camilamacedo86 · 2025-07-24T20:49:21Z

/test e2e-gcp-operator

camilamacedo86 · 2025-07-24T20:49:27Z

/test e2e-aws-ovn-serial

camilamacedo86 · 2025-07-25T06:04:24Z

/test e2e-aws-ovn-serial

camilamacedo86 · 2025-07-25T08:21:45Z

/test e2e-gcp-operator

camilamacedo86 · 2025-07-29T13:33:50Z

/retest-required

camilamacedo86 · 2025-07-29T18:09:59Z

/test e2e-gcp-operator
/test e2e-aws-ovn-serial

openshift-ci-robot · 2025-08-01T16:49:04Z

@camilamacedo86: This pull request references Jira Issue OCPBUGS-60060, which is invalid:

expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Description of the change:
The manifest for the IBM pod is outdated and has not fixes done since our make manifest is broken and has not been used to validate the changes in the CI

The following fix were applied to the IBM pod

NO-ISSUE: Add readonlyRootFilesystem #634

OCPBUGS-17157: manifests: tune memory use #526

Motivation for the change:

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation

Sufficient unit test coverage

Sufficient end-to-end test coverage

Docs updated or added to /docs

Commit messages sensible and descriptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

camilamacedo86 · 2025-08-01T17:51:29Z

/test e2e-gcp-operator

kevinrizza · 2025-08-01T18:03:27Z

/lgtm

camilamacedo86 · 2025-08-01T18:09:57Z

        seccompProfile:
          type: RuntimeDefault
      serviceAccountName: marketplace-operator
-      nodeSelector: {}


@kuiwang02 @jianzhangbjz

Could you please help us to know if we are testing the IBM pod in any place?
Have we a test for :

config.openshift.io/inject-proxy: "marketplace-operator" include.release.openshift.io/hypershift: "true" include.release.openshift.io/ibm-cloud-managed: "true" capability.openshift.io/name: "marketplace"

Yes, but we don't own it since it's an IBM release. You can search powervs-ipi-f7 in Prow jobs: https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/

The code is part of this repository
So, we need to have a test to ensure it as a pre-merge.
Not sure if I understand how that works

grokspawn · 2025-08-01T18:14:20Z

      serviceAccountName: marketplace-operator
-      nodeSelector: {}
+      nodeSelector:
+        node-role.kubernetes.io/master: ""


Isn't this supposed to now be .../control-plane? See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.20.md#urgent-upgrade-notes

I expect that OCP will respect both labels for probably eternity, but we should at least introduce the new label as well.

/hold until we resolve ^^^

Hi @grokspawn

Thank you a lot !!!

We can go now :-) To do what we need to do here, we do not need this one
I added it because the manifest was updated manually, looking at the operator.yaml
In a follow up we might need to change here: https://github.com/operator-framework/operator-marketplace/blob/master/manifests/09_operator.yaml#L29-L30

/hold cancel

…on applied to operator manually

openshift-ci · 2025-08-01T22:34:53Z

@camilamacedo86: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`c05bf44`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

camilamacedo86 · 2025-08-02T08:10:24Z

/restest required

camilamacedo86 · 2025-08-04T12:36:04Z

/retest-required

camilamacedo86 · 2025-08-05T16:22:40Z

/jira refresh

jianzhangbjz · 2025-08-06T03:31:58Z

Hi Camila, as Brad mentioned in the https://redhat-internal.slack.com/archives/CNHC2DK2M/p1754450434695989?thread_ts=1754277789.143609&cid=CNHC2DK2M, it seems we’re unable to run pre-merge tests for this PR. So I think we can proceed with the testing after it has been merged.

camilamacedo86 · 2025-08-06T07:38:03Z

/jira refresh

openshift-ci-robot · 2025-08-06T07:38:10Z

@camilamacedo86: This pull request references Jira Issue OCPBUGS-60060, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.0) matches configured target version for branch (4.20.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

camilamacedo86 · 2025-08-06T07:38:49Z

Hi @jianzhangbjz

Could you please LGTM the pr so we get it merged?
Then we do the test?

jianzhangbjz · 2025-08-06T07:43:53Z

/lgtm
/label qe-approved

openshift-ci-robot · 2025-08-06T10:34:45Z

@camilamacedo86: Jira Issue OCPBUGS-60060: All pull requests linked via external trackers have merged:

operator-framework/operator-marketplace#649

Jira Issue OCPBUGS-60060 has been moved to the MODIFIED state.

Details

In response to this:

Description of the change:
The manifest for the IBM pod is outdated and has not fixes done since our make manifest is broken and has not been used to validate the changes in the CI

The following fix were applied to the IBM pod

NO-ISSUE: Add readonlyRootFilesystem #634

OCPBUGS-17157: manifests: tune memory use #526

Motivation for the change:

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation

Sufficient unit test coverage

Sufficient end-to-end test coverage

Docs updated or added to /docs

Commit messages sensible and descriptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2025-08-06T12:37:29Z

[ART PR BUILD NOTIFIER]

Distgit: marketplace-operator
This PR has been included in build marketplace-operator-container-v4.20.0-202508061146.p0.g68194dd.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci Bot requested review from ankitathomas and grokspawn July 24, 2025 10:56

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2025

camilamacedo86 commented Jul 24, 2025

View reviewed changes

Comment thread manifests/09_operator-ibm-cloud-managed.yaml

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2025

perdasilva force-pushed the manifests branch from 5f6e586 to 2f1be6b Compare July 25, 2025 12:01

camilamacedo86 force-pushed the manifests branch 2 times, most recently from 5935327 to c606281 Compare August 1, 2025 16:19

camilamacedo86 changed the title ~~Upgrade manifests : run make manifests~~ (fix) Update the operator-ibm-cloud-managed with the same configuration applied to operator manually Aug 1, 2025

camilamacedo86 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2025

camilamacedo86 changed the title ~~(fix) Update the operator-ibm-cloud-managed with the same configuration applied to operator manually~~ OCPBUGS-60060 (fix) Update the operator-ibm-cloud-managed with the same configuration applied to operator manually Aug 1, 2025

camilamacedo86 changed the title ~~OCPBUGS-60060 (fix) Update the operator-ibm-cloud-managed with the same configuration applied to operator manually~~ OCPBUGS-60060: (fix) Update the operator-ibm-cloud-managed with the same configuration applied to operator manually Aug 1, 2025

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 1, 2025

openshift-ci Bot assigned kevinrizza Aug 1, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2025

camilamacedo86 commented Aug 1, 2025

View reviewed changes

grokspawn reviewed Aug 1, 2025

View reviewed changes

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2025

(fix) Update the operator-ibm-cloud-managed with the same configurati…

c05bf44

…on applied to operator manually

camilamacedo86 force-pushed the manifests branch from c606281 to c05bf44 Compare August 1, 2025 18:17

openshift-ci Bot removed lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 1, 2025

camilamacedo86 requested review from grokspawn and jianzhangbjz August 5, 2025 16:22

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 6, 2025

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Aug 6, 2025

openshift-ci Bot assigned jianzhangbjz Aug 6, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2025

openshift-merge-bot Bot merged commit 68194dd into operator-framework:master Aug 6, 2025
10 of 11 checks passed

camilamacedo86 deleted the manifests branch August 6, 2025 13:08

Conversation

camilamacedo86 commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Jul 24, 2025

Uh oh!

Uh oh!

camilamacedo86 commented Jul 24, 2025

Uh oh!

camilamacedo86 commented Jul 24, 2025

Uh oh!

camilamacedo86 commented Jul 25, 2025

Uh oh!

camilamacedo86 commented Jul 25, 2025

Uh oh!

camilamacedo86 commented Jul 29, 2025

Uh oh!

camilamacedo86 commented Jul 29, 2025

Uh oh!

openshift-ci-robot commented Aug 1, 2025

Uh oh!

camilamacedo86 commented Aug 1, 2025

Uh oh!

kevinrizza commented Aug 1, 2025

Uh oh!

camilamacedo86 Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

jianzhangbjz Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

grokspawn Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

grokspawn Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camilamacedo86 commented Aug 2, 2025

Uh oh!

camilamacedo86 commented Aug 4, 2025

Uh oh!

camilamacedo86 commented Aug 5, 2025

Uh oh!

jianzhangbjz commented Aug 6, 2025

Uh oh!

camilamacedo86 commented Aug 6, 2025

Uh oh!

openshift-ci-robot commented Aug 6, 2025

Uh oh!

camilamacedo86 commented Aug 6, 2025

Uh oh!

jianzhangbjz commented Aug 6, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 6, 2025

Uh oh!

openshift-bot commented Aug 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

camilamacedo86 commented Jul 24, 2025 •

edited

Loading

openshift-ci Bot commented Aug 1, 2025 •

edited

Loading