Skip to content

OCPBUGS-17157: manifests: tune memory use#526

Merged
openshift-merge-robot merged 1 commit intooperator-framework:masterfrom
stevekuznetsov:skuznets/memory-tuning
Aug 4, 2023
Merged

OCPBUGS-17157: manifests: tune memory use#526
openshift-merge-robot merged 1 commit intooperator-framework:masterfrom
stevekuznetsov:skuznets/memory-tuning

Conversation

@stevekuznetsov
Copy link
Copy Markdown
Contributor

@stevekuznetsov stevekuznetsov commented Aug 3, 2023

We do basically nothing in this controller - we watch an extremely small set of objects and make very few allocations past our informer queues. We should not be using much memory, ever.

@stevekuznetsov
manifests: tune memory use
2504ccd 
We do basically nothing in this controller - we watch an extremely
small set of objects and make very few allocations past our informer
queues. We should not be using much memory, ever.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 3, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 3, 2023

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17157, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

We do basically nothing in this controller - we watch an extremely small set of objects and make very few allocations past our informer queues. We should not be using much memory, ever.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from jianzhangbjz August 3, 2023 15:22
@stevekuznetsov stevekuznetsov mentioned this pull request Aug 3, 2023
Closed
38 tasks
@openshift-ci openshift-ci Bot requested review from anik120 and awgreene August 3, 2023 15:22
perdasilva
perdasilva approved these changes Aug 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, perdasilva, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 3, 2023

/retest

@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 3, 2023

/test okd-scos-e2e-gcp

@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 3, 2023

/test e2e-aws-ovn-serial

@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 4, 2023

/test okd-scos-e2e-gcp

@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 4, 2023
Merged
@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 4, 2023

/retest

@stevekuznetsov stevekuznetsov added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit f5d7524 into operator-framework:master Aug 4, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 4, 2023

@stevekuznetsov: Jira Issue OCPBUGS-17157: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-17157 has not been moved to the MODIFIED state.

Details

In response to this:

We do basically nothing in this controller - we watch an extremely small set of objects and make very few allocations past our informer queues. We should not be using much memory, ever.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 4, 2023
Merged
Merged
Merged
Merged
This was referenced Aug 15, 2023
Merged
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 24, 2023
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 5, 2023
Merged
This was referenced Sep 6, 2023
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 18, 2023
Merged
This was referenced Sep 26, 2023
Merged
Merged
@camilamacedo86 camilamacedo86 mentioned this pull request Aug 1, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perdasilva perdasilva perdasilva approved these changes

@everettraven everettraven everettraven approved these changes

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

@anik120 anik120 Awaiting requested review from anik120

@awgreene awgreene Awaiting requested review from awgreene

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stevekuznetsov @openshift-ci-robot @perdasilva @everettraven @openshift-merge-robot