Skip to content

NO-ISSUE: Add readonlyRootFilesystem#634

Merged
openshift-merge-bot[bot] merged 5 commits intooperator-framework:masterfrom
ShazaAldawamneh:OCPSTRAT-1976
Jul 9, 2025
Merged

NO-ISSUE: Add readonlyRootFilesystem#634
openshift-merge-bot[bot] merged 5 commits intooperator-framework:masterfrom
ShazaAldawamneh:OCPSTRAT-1976

Conversation

@ShazaAldawamneh
Copy link
Copy Markdown
Contributor

@ShazaAldawamneh ShazaAldawamneh commented May 28, 2025 •
edited
Loading

Description of the change:

Enforce readOnlyRootFilesystem: true for enhanced security (and provide brief justification for false exceptions)
Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@ShazaAldawamneh
Add readonlyRootFilesystem
df2958b 
Signed-off-by: Shaza Aldawamneh <shaza.aldawamneh@hotmail.com>
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 28, 2025
@openshift-ci openshift-ci Bot requested review from grokspawn and tmshort May 28, 2025 13:05
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 28, 2025

Hi @ShazaAldawamneh. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Jun 10, 2025

/lgtm
/approve

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 10, 2025
@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Jun 10, 2025

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 10, 2025
@ShazaAldawamneh
Copy link
Copy Markdown
Contributor Author

ShazaAldawamneh commented Jun 10, 2025

/retest-required

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Jun 11, 2025

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 11, 2025

@perdasilva: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@perdasilva perdasilva changed the title Add readonlyRootFilesystem NO-ISSUE: Add readonlyRootFilesystem Jun 11, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 11, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 11, 2025

@ShazaAldawamneh: This pull request explicitly references no jira issue.

Details

In response to this:

Description of the change:

Enforce readOnlyRootFilesystem: true for enhanced security (and provide brief justification for false exceptions)
Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86
Copy link
Copy Markdown
Contributor

camilamacedo86 commented Jun 24, 2025

/test e2e-aws-ovn-serial

camilamacedo86
camilamacedo86 approved these changes Jun 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, perdasilva, ShazaAldawamneh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Copy Markdown
Contributor

camilamacedo86 commented Jun 24, 2025

/test e2e-aws-ovn-serial

3 similar comments
@camilamacedo86
Copy link
Copy Markdown
Contributor

camilamacedo86 commented Jun 24, 2025

/test e2e-aws-ovn-serial

@camilamacedo86
Copy link
Copy Markdown
Contributor

camilamacedo86 commented Jun 25, 2025

/test e2e-aws-ovn-serial

@ShazaAldawamneh
Copy link
Copy Markdown
Contributor Author

ShazaAldawamneh commented Jun 30, 2025

/test e2e-aws-ovn-serial

@ShazaAldawamneh
Add readonlyRootFilesystem
30fc8b8 
Signed-off-by: Shaza Aldawamneh <shaza.aldawamneh@hotmail.com>
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2025
@ShazaAldawamneh
Add readonlyRootFilesystem
1349a55 
Signed-off-by: Shaza Aldawamneh <shaza.aldawamneh@hotmail.com>
@ShazaAldawamneh
Add readonlyRootFilesystem
20b8fbb 
Signed-off-by: Shaza Aldawamneh <shaza.aldawamneh@hotmail.com>
@dusk125
Copy link
Copy Markdown

dusk125 commented Jul 1, 2025

/retest-required

@ShazaAldawamneh
addressing test fix
0a248ed 
Signed-off-by: Shaza Aldawamneh <shaza.aldawamneh@hotmail.com>
@dusk125
Copy link
Copy Markdown

dusk125 commented Jul 2, 2025

/retest-required

2 similar comments
@dusk125
Copy link
Copy Markdown

dusk125 commented Jul 2, 2025

/retest-required

@dusk125
Copy link
Copy Markdown

dusk125 commented Jul 3, 2025

/retest-required

@jacobsee
Copy link
Copy Markdown

jacobsee commented Jul 3, 2025

Hi @perdasilva, @camilamacedo86! Looks like there's been a test fix since the last time you were here, but it's passing now. Mind reviewing once more please? 😄

@dusk125
Copy link
Copy Markdown

dusk125 commented Jul 9, 2025

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 9, 2025

@dusk125: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@everettraven
Copy link
Copy Markdown
Contributor

everettraven commented Jul 9, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 02c1fe9 into operator-framework:master Jul 9, 2025
10 checks passed
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 9, 2025

[ART PR BUILD NOTIFIER]

Distgit: marketplace-operator
This PR has been included in build marketplace-operator-container-v4.20.0-202507091614.p0.g02c1fe9.assembly.stream.el9.
All builds following this will include this PR.

@camilamacedo86 camilamacedo86 mentioned this pull request Aug 1, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@grokspawn grokspawn Awaiting requested review from grokspawn

@tmshort tmshort Awaiting requested review from tmshort

Assignees

@perdasilva perdasilva

@camilamacedo86 camilamacedo86

@everettraven everettraven

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ShazaAldawamneh @perdasilva @openshift-ci-robot @camilamacedo86 @dusk125 @jacobsee @everettraven @openshift-bot