Skip to content

OCPBUGS-17157: bump controller-runtime, expose pprof, watch only one configmap#525

Merged
openshift-merge-robot merged 3 commits intooperator-framework:masterfrom
stevekuznetsov:skuznets/watch-one-configmap
Aug 3, 2023
Merged

OCPBUGS-17157: bump controller-runtime, expose pprof, watch only one configmap#525
openshift-merge-robot merged 3 commits intooperator-framework:masterfrom
stevekuznetsov:skuznets/watch-one-configmap

Conversation

@stevekuznetsov
Copy link
Copy Markdown
Contributor

@stevekuznetsov stevekuznetsov commented Aug 1, 2023

go.mod: bump controller-runtime

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

manager: only watch the one ConfigMap we care about

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

manager: serve pprof endpoints

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

@stevekuznetsov
go.mod: bump controller-runtime
e28fbf7 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
manager: only watch the one ConfigMap we care about
3421499 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-ci openshift-ci Bot requested review from anik120 and ankitathomas August 1, 2023 13:13
@kevinrizza
Copy link
Copy Markdown
Member

kevinrizza commented Aug 1, 2023

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@stevekuznetsov stevekuznetsov changed the title bump controller-runtime, expose pprof, watch only one configmap OCPBUGS-17157: bump controller-runtime, expose pprof, watch only one configmap Aug 1, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 1, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 1, 2023

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17157, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

go.mod: bump controller-runtime

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

manager: only watch the one ConfigMap we care about

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

manager: serve pprof endpoints

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from jianzhangbjz August 1, 2023 15:20
@stevekuznetsov stevekuznetsov mentioned this pull request Aug 2, 2023
Closed
38 tasks
@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 2, 2023

/retest

1 similar comment
@stevekuznetsov
Copy link
Copy Markdown
Contributor Author

stevekuznetsov commented Aug 2, 2023

/retest

@stevekuznetsov
manager: serve pprof endpoints
462d820 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov stevekuznetsov force-pushed the skuznets/watch-one-configmap branch from 79690fc to 462d820 Compare August 2, 2023 23:15
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@grokspawn
Copy link
Copy Markdown
Contributor

grokspawn commented Aug 2, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 3, 2023

@stevekuznetsov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-gcp 462d820 link false /test okd-e2e-gcp
ci/prow/okd-scos-e2e-gcp 462d820 link false /test okd-scos-e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f23122c into operator-framework:master Aug 3, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 3, 2023

@stevekuznetsov: Jira Issue OCPBUGS-17157: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-17157 has not been moved to the MODIFIED state.

Details

In response to this:

go.mod: bump controller-runtime

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

manager: only watch the one ConfigMap we care about

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

manager: serve pprof endpoints

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 3, 2023
Merged
Merged
Merged
Merged
This was referenced Aug 4, 2023
Merged
Merged
Merged
This was referenced Aug 15, 2023
Merged
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 24, 2023
Merged
This was referenced Sep 5, 2023
Merged
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 18, 2023
Merged
This was referenced Sep 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anik120 anik120 Awaiting requested review from anik120

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

Assignees

@kevinrizza kevinrizza

@grokspawn grokspawn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stevekuznetsov @kevinrizza @openshift-ci-robot @grokspawn @openshift-merge-robot