Skip to content

feat: Add getSerial for room sensors#369

Merged
woehrl01 merged 3 commits into
openviess:masterfrom
CFenner:patch-6
May 24, 2024
Merged

feat: Add getSerial for room sensors#369
woehrl01 merged 3 commits into
openviess:masterfrom
CFenner:patch-6

Conversation

@CFenner
Copy link
Copy Markdown
Member

@CFenner CFenner commented May 9, 2024

This exposes the deviceID of room temp sensors and TRVs to be used in HA to identify the device.

https://github.com/somm15/PyViCare/blob/f8d1b446d3b74fb73d55552461c6e26b450923af/tests/response/zigbee_zk03839.json#L28

@CFenner
Copy link
Copy Markdown
Member Author

CFenner commented May 24, 2024

Linter issues are unrelated to these changes and should be fixed in a separate PR:

************* Module PyViCare.PyViCareHeatPump
PyViCare/PyViCareHeatPump.py:112:4: W0105: String statement has no effect (pointless-string-statement)
PyViCare/PyViCareHeatPump.py:140:4: W0105: String statement has no effect (pointless-string-statement)

-----------------------------------
Your code has been rated at 9.99/10

@woehrl01 woehrl01 merged commit 4e3bbdc into openviess:master May 24, 2024

@handleNotSupported
def getSerial(self):
return self.service.getProperty("device.sensors.temperature")["deviceId"]
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessing device.sensors.temperature does work for temp sensors and TRVs (see test data). This is a workaround as long as Viessmann does not provide device.serial on zigged devices (see https://community.viessmann.de/t5/Feedback-API/Serial-Number-an-Gateways/td-p/410253)

@CFenner CFenner deleted the patch-6 branch May 24, 2024 08:27
@CFenner CFenner changed the title feat(room sensor): expose deviceID feat: Add getSerial for room sensors Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants