feat: Add getSerial for room sensors#369
Merged
Merged
Conversation
Member
Author
|
Linter issues are unrelated to these changes and should be fixed in a separate PR: |
CFenner
commented
May 24, 2024
|
|
||
| @handleNotSupported | ||
| def getSerial(self): | ||
| return self.service.getProperty("device.sensors.temperature")["deviceId"] |
Member
Author
There was a problem hiding this comment.
Accessing device.sensors.temperature does work for temp sensors and TRVs (see test data). This is a workaround as long as Viessmann does not provide device.serial on zigged devices (see https://community.viessmann.de/t5/Feedback-API/Serial-Number-an-Gateways/td-p/410253)
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exposes the
deviceIDof room temp sensors and TRVs to be used in HA to identify the device.https://github.com/somm15/PyViCare/blob/f8d1b446d3b74fb73d55552461c6e26b450923af/tests/response/zigbee_zk03839.json#L28