Skip to content

feat: Add getSerial for room sensors #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woehrl01 merged 3 commits into from
May 24, 2024
Merged

feat: Add getSerial for room sensors #369

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96e2591
Update PyViCareRoomSensor.py
CFenner May 9, 2024
2399cf4
fix trailing whitespaces
CFenner May 24, 2024
8265b9d
Update PyViCareRoomSensor.py
CFenner May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions PyViCare/PyViCareRoomSensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

class RoomSensor(Device):

@handleNotSupported
def getSerial(self):
return self.service.getProperty("device.sensors.temperature")["deviceId"]
Copy link
Copy Markdown
Member Author

@CFenner CFenner May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessing device.sensors.temperature does work for temp sensors and TRVs (see test data). This is a workaround as long as Viessmann does not provide device.serial on zigged devices (see https://community.viessmann.de/t5/Feedback-API/Serial-Number-an-Gateways/td-p/410253)


@handleNotSupported
def getTemperature(self):
return self.service.getProperty("device.sensors.temperature")["properties"]["value"]["value"]
Expand Down