Skip to content

Change ViCare dependency back to original one#127168

Merged
MartinHjelmare merged 1 commit into
home-assistant:devfrom
CFenner:deps
Oct 1, 2024
Merged

Change ViCare dependency back to original one#127168
MartinHjelmare merged 1 commit into
home-assistant:devfrom
CFenner:deps

Conversation

@CFenner
Copy link
Copy Markdown
Contributor

@CFenner CFenner commented Oct 1, 2024

Proposed change

As discussed with @MartinHjelmare this changes the dependency back to the original one. We moved the personal repository https://github.com/openviess/PyViCare to a dedicated org now. I applied and released the same fixes as on my fork https://github.com/CFenner/PyViCare/ (PyViCare-neo).

Changes: https://github.com/openviess/PyViCare/releases

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@CFenner CFenner marked this pull request as ready for review October 1, 2024 08:05
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 5bf5545 into home-assistant:dev Oct 1, 2024
@CFenner CFenner deleted the deps branch October 1, 2024 09:32
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants