Repository navigation
UCT/ROCM: adjust hsa memory type check for new rocm releases - #11236
Merged
Merged
Conversation
Newer rocm releases return HSA_EXT_POINTER_TYPE_RESERVED_ADDR instead of HSA_EXT_POINTER_TYPE_UNKNOWN for hip managed memory. Add rocm version detection and guard code based on the detected version
mshanthagit
force-pushed
the
pr/hipMallocManaged-fix
branch
from
March 5, 2026 22:33
0e5689e to
8e00804
Compare
tvegas1
reviewed
Mar 6, 2026
Contributor
|
Need to add diff below to unblock CI: diff --git a/AUTHORS b/AUTHORS
index 9918baff3..5612420e9 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -67,6 +67,7 @@ Leonid Genkin <lgenkin@nvidia.com>
Lior Paz <liorpa@nvidia.com>
Luis E. Pena <l31g@hotmail.com>
Manjunath Gorentla Venkata <manjugv@gmail.com>
+Manu Shantharam <manu.shantharam@amd.com>
Marek Schimara <Marek.Schimara@bull.net>
Mark Allen <markalle@us.ibm.com>
Matthew Baker <bakermb@ornl.gov> |
yosefe
approved these changes
Mar 7, 2026
yosefe
enabled auto-merge (squash)
March 7, 2026 12:19
mshanthagit
added a commit
to mshanthagit/ucx
that referenced
this pull request
Mar 10, 2026
…#11236) * UCT/ROCM: adjust hsa memory type check for new rocm releases Newer rocm releases return HSA_EXT_POINTER_TYPE_RESERVED_ADDR instead of HSA_EXT_POINTER_TYPE_UNKNOWN for hip managed memory. Add rocm version detection and guard code based on the detected version * UCT/ROCM: Fix formatting issue and update the Copyright date * UCT/ROCM: Addressing review comments
yosefe
pushed a commit
that referenced
this pull request
Mar 11, 2026
#11244) UCT/ROCM: adjust hsa memory type check for new rocm releases (#11236) * UCT/ROCM: adjust hsa memory type check for new rocm releases Newer rocm releases return HSA_EXT_POINTER_TYPE_RESERVED_ADDR instead of HSA_EXT_POINTER_TYPE_UNKNOWN for hip managed memory. Add rocm version detection and guard code based on the detected version * UCT/ROCM: Fix formatting issue and update the Copyright date * UCT/ROCM: Addressing review comments
jeynmann
pushed a commit
to jeynmann/ucx
that referenced
this pull request
Mar 17, 2026
…#11236) * UCT/ROCM: adjust hsa memory type check for new rocm releases Newer rocm releases return HSA_EXT_POINTER_TYPE_RESERVED_ADDR instead of HSA_EXT_POINTER_TYPE_UNKNOWN for hip managed memory. Add rocm version detection and guard code based on the detected version * UCT/ROCM: Fix formatting issue and update the Copyright date * UCT/ROCM: Addressing review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer rocm releases return HSA_EXT_POINTER_TYPE_RESERVED_ADDR instead of HSA_EXT_POINTER_TYPE_UNKNOWN for hip managed memory.
Add rocm version detection and guard code based on the detected version
What?
Adding functionality to detect rocm version and enable code paths based on the version.
Why?
Some of the hip tests related to "managed memory" are failing with rocm 7.x
How?
It is optional, but for complex PRs, please provide information about the design,
architecture, approach, etc.