Skip to content

UCT/ROCM: adjust hsa memory type check for new rocm releases #11236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yosefe merged 3 commits into from
Mar 7, 2026
Merged

UCT/ROCM: adjust hsa memory type check for new rocm releases #11236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fbf17b
UCT/ROCM: adjust hsa memory type check for new rocm releases
mshanthagit Feb 25, 2026
8e00804
UCT/ROCM: Fix formatting issue and update the Copyright date
mshanthagit Mar 5, 2026
050540f
UCT/ROCM: Addressing review comments
mshanthagit Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ Leonid Genkin <lgenkin@nvidia.com>
Lior Paz <liorpa@nvidia.com>
Luis E. Pena <l31g@hotmail.com>
Manjunath Gorentla Venkata <manjugv@gmail.com>
Manu Shantharam <manu.shantharam@amd.com>
Marek Schimara <Marek.Schimara@bull.net>
Mark Allen <markalle@us.ibm.com>
Matthew Baker <bakermb@ornl.gov>
Expand Down
18 changes: 17 additions & 1 deletion config/m4/rocm.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# Copyright (C) Advanced Micro Devices, Inc. 2016 - 2023. ALL RIGHTS RESERVED.
# Copyright (C) Advanced Micro Devices, Inc. 2016 - 2026. ALL RIGHTS RESERVED.
# Copyright (c) NVIDIA CORPORATION & AFFILIATES, 2001-2018. ALL RIGHTS RESERVED.
# See file LICENSE for terms.
#
Expand Down Expand Up @@ -97,6 +97,22 @@ AS_IF([test "x$with_rocm" != "xno"],
AC_SUBST([ROCM_LIBS])
AC_SUBST([ROCM_ROOT])],
[AC_MSG_WARN([ROCm not found])])

AS_IF([test "x$rocm_happy" = "xyes"],
[HIP_BUILD_FLAGS([$with_rocm], [HIP_LIBS], [HIP_LDFLAGS], [HIP_CPPFLAGS])
CPPFLAGS="$HIP_CPPFLAGS $CPPFLAGS"

AC_MSG_CHECKING([for HIP version])
AC_COMPUTE_INT([hip_version], [HIP_VERSION],
[#include <hip_version.h>],
[hip_version=0])
AC_MSG_RESULT(["$hip_version"])
CPPFLAGS="$SAVE_CPPFLAGS"])

AS_IF([test "$hip_version" -ge 70000000],
[AC_DEFINE([HAVE_ROCM_RESERVED_ADDR_TYPE], [1],
Comment thread
tvegas1 marked this conversation as resolved.
Resolved
[ROCm 7.0+ has HSA_EXT_POINTER_TYPE_RESERVED_ADDR])])

AC_CHECK_FUNCS([hsa_amd_portable_export_dmabuf])

CPPFLAGS="$SAVE_CPPFLAGS"
Expand Down
11 changes: 9 additions & 2 deletions src/uct/rocm/base/rocm_base.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) Advanced Micro Devices, Inc. 2019-2023. ALL RIGHTS RESERVED.
* Copyright (C) Advanced Micro Devices, Inc. 2019-2026. ALL RIGHTS RESERVED.
* See file LICENSE for terms.
*/

Expand Down Expand Up @@ -251,7 +251,14 @@ hsa_status_t uct_rocm_base_get_ptr_info(void *ptr, size_t size, void **base_ptr,
*base_size = info.sizeInBytes;
}
if (dev_type != NULL) {
if (info.type == HSA_EXT_POINTER_TYPE_UNKNOWN) {
/* HSA_EXT_POINTER_TYPE_RESERVED_ADDR check is required
* for rocm7+ for hip managed memory
*/
if ((info.type == HSA_EXT_POINTER_TYPE_UNKNOWN)
#ifdef HAVE_ROCM_RESERVED_ADDR_TYPE
Comment thread
tvegas1 marked this conversation as resolved.
Resolved
|| (info.type == HSA_EXT_POINTER_TYPE_RESERVED_ADDR)
#endif
) {
*dev_type = HSA_DEVICE_TYPE_CPU;
} else {
status = hsa_agent_get_info(info.agentOwner, HSA_AGENT_INFO_DEVICE,
Expand Down
Loading