Repository navigation
UCT/ROCM: adjust hsa memory type check for new rocm releases - v1.20.x - #11244
Merged
yosefe merged 1 commit intoMar 11, 2026
Merged
Conversation
…#11236) * UCT/ROCM: adjust hsa memory type check for new rocm releases Newer rocm releases return HSA_EXT_POINTER_TYPE_RESERVED_ADDR instead of HSA_EXT_POINTER_TYPE_UNKNOWN for hip managed memory. Add rocm version detection and guard code based on the detected version * UCT/ROCM: Fix formatting issue and update the Copyright date * UCT/ROCM: Addressing review comments
mshanthagit
marked this pull request as ready for review
March 10, 2026 05:27
tvegas1
approved these changes
Mar 10, 2026
tvegas1
changed the title
Contributor
Author
|
@tvegas1 can you please merge this PR so that it can be part of the next release (1.20.1?)? |
yosefe
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer rocm releases return HSA_EXT_POINTER_TYPE_RESERVED_ADDR instead of HSA_EXT_POINTER_TYPE_UNKNOWN for hip managed memory.
Add rocm version detection and guard code based on the detected version
UCT/ROCM: Fix formatting issue and update the Copyright date
UCT/ROCM: Addressing review comments
What?
Cherry-picking the commit from the master branch
Why?
Bug-fix being propagated from master to v1.20.x
How?
It is optional, but for complex PRs, please provide information about the design,
architecture, approach, etc.