feat(sdk): Load KAS keys from policy service #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
jakedoublev
reviewed
Aug 14, 2024
jakedoublev
reviewed
Aug 14, 2024
Contributor
|
Sorry, just realized those comments ^^ should be on #1347 instead. Resolving here and adding there. |
Contributor
|
Warning This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description. |
jakedoublev
reviewed
Aug 19, 2024
Contributor
|
This looks good to me, but it looks like the pipeline is ❌ and it will probably have conflicts with #1318 ? |
Deferred to not block releases until everything is bumped
Lots of things are declared in the sdk package, so this is easier than factoring shared items into a helper package that would otherwise introduce bidirectional package deps between sdk (root) and autoconfigure (internal) packages
- Lets the SDK load kas keys from the policy service - This was removed/unsupported before, since the SDK requires Key IDs, but the service previously did not store them - Adds a sample round trip that loads a key from a non-existant KAS to validate that the SDK doesn't call out when the key is loaded into the policy service
dmihalcik-virtru
force-pushed
the
feature/store-kid-2
branch
from
d853a82 to
bcfc0d7
Compare
Member
Author
yes, I'll fix that up after merging this. |
jakedoublev
reviewed
Aug 19, 2024
jakedoublev
previously approved these changes
Aug 19, 2024
strantalis
approved these changes
Aug 20, 2024
This was referenced Aug 19, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.14](protocol/go/v0.2.13...protocol/go/v0.2.14) (2024-08-20) ### Features * **policy:** 1277 protos and service methods for Resource Mapping Groups operations ([#1343](#1343)) ([570f402](570f402)) * **sdk:** Load KAS keys from policy service ([#1346](#1346)) ([fe628a0](fe628a0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.9](sdk/v0.3.8...sdk/v0.3.9) (2024-08-20) ### Features * **sdk:** Load KAS keys from policy service ([#1346](#1346)) ([fe628a0](fe628a0)) * **sdk:** support oauth2 tokensource with option ([#1394](#1394)) ([2886c0f](2886c0f)), closes [#1307](#1307) ### Bug Fixes * **core:** Autobump sdk ([#1402](#1402)) ([192e5e5](192e5e5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Co-authored-by: Jake Van Vorhis <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.19](service/v0.4.18...service/v0.4.19) (2024-08-20) ### Features * **core:** add RPCs to namespaces service to handle assignment/removal of KAS grants ([#1344](#1344)) ([ee47d6c](ee47d6c)) * **core:** Adds key ids to kas registry ([#1347](#1347)) ([e6c76ee](e6c76ee)) * **core:** further support in policy for namespace grants ([#1334](#1334)) ([d56231e](d56231e)) * **core:** support grants to namespaces, definitions, and values in GetAttributeByValueFqns ([#1353](#1353)) ([42a3d74](42a3d74)) * **core:** validate kas uri ([#1351](#1351)) ([2b70931](2b70931)) * **policy:** 1277 protos and service methods for Resource Mapping Groups operations ([#1343](#1343)) ([570f402](570f402)) * **sdk:** Load KAS keys from policy service ([#1346](#1346)) ([fe628a0](fe628a0)) * **sdk:** public client and other enhancements to well-known SDK functionality ([#1365](#1365)) ([3be50a4](3be50a4)) ### Bug Fixes * **authz:** Add http routes for authorization to casbin policy ([#1355](#1355)) ([3fbaf59](3fbaf59)) * **core:** align keycloak provisioning in one command ([#1381](#1381)) ([c3611d2](c3611d2)), closes [#1380](#1380) * **core:** align policy kas grant assignments http gateway methods with actions ([#1299](#1299)) ([031c6ca](031c6ca)) * **core:** Autobump service ([#1340](#1340)) ([3414670](3414670)) * **core:** Autobump service ([#1369](#1369)) ([2ac2378](2ac2378)) * **core:** Autobump service ([#1403](#1403)) ([8084e3e](8084e3e)) * **core:** Autobump service ([#1405](#1405)) ([74a7f0c](74a7f0c)) * **core:** bump go version to 1.22 ([#1407](#1407)) ([c696cd1](c696cd1)) * **core:** cleanup sensitive info being logged from configuration ([#1366](#1366)) ([2b6cf62](2b6cf62)) * **core:** policy kas grants list (filter params and namespace grants) ([#1342](#1342)) ([f18ba68](f18ba68)) * **core:** policy migrations timestamps merge order ([#1325](#1325)) ([2bf4290](2bf4290)) * **sdk:** align sdk with platform modes ([#1328](#1328)) ([88ca6f7](88ca6f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.