fix(sdk): let value grants override attr grants #1318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If both a value and its attr have a grant assigned, only use the value grant. - Part of #1296
This comment has been minimized.
This comment has been minimized.
Contributor
|
Warning This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description. |
Contributor
|
I'm not sure I can approve/attest to the split strategy and tests of different key types, but these lines look good to me regarding a value grant having specificity over a definition grant: https://github.com/opentdf/platform/pull/1318/files#diff-23ebbe4ac8b2e6c1b319e2927a1e6bd56e3dc0aa79e8c7324ee989f423aeef7dR233-R239 |
…entdf/platform into feature/specificity-overloads
strantalis
approved these changes
Aug 21, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.10](sdk/v0.3.9...sdk/v0.3.10) (2024-08-21) ### Bug Fixes * **sdk:** 🔒 During read, limits TDF Manifest to 10MB ([#1385](#1385)) ([cfeebce](cfeebce)) * **sdk:** let value grants override attr grants ([#1318](#1318)) ([77f1e11](77f1e11)) * **sdk:** well-known warning logs and public client id error ([#1415](#1415)) ([e6e76bf](e6e76bf)), closes [#1414](#1414) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.