feat(sdk): support oauth2 tokensource with option #1394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jentfoo
reviewed
Aug 20, 2024
Contributor
jentfoo
left a comment
jentfoo
left a comment
There was a problem hiding this comment.
Some initial comments, I assume this is a WIP since unit tests are missing.
jrschumacher
approved these changes
Aug 20, 2024
jentfoo
approved these changes
Aug 20, 2024
Contributor
jentfoo
left a comment
jentfoo
left a comment
There was a problem hiding this comment.
LGTM, thank you for the updates! One comment to consider for the future
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.9](sdk/v0.3.8...sdk/v0.3.9) (2024-08-20) ### Features * **sdk:** Load KAS keys from policy service ([#1346](#1346)) ([fe628a0](fe628a0)) * **sdk:** support oauth2 tokensource with option ([#1394](#1394)) ([2886c0f](2886c0f)), closes [#1307](#1307) ### Bug Fixes * **core:** Autobump sdk ([#1402](#1402)) ([192e5e5](192e5e5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Co-authored-by: Jake Van Vorhis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1307