Skip to content

Conversation

@ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Jul 5, 2024

For openshift/sriov-network-operator#955

Not sure if additional files need to change here since more than one dockerfile names were changed, please verify

@zeeke
Copy link
Contributor

zeeke commented Jul 10, 2024

Not sure if additional files need to change here since more than one dockerfile names were changed, please verify

The same file contains references to all those Dockerfiles:

https://github.com/openshift/release/pull/54079/files#diff-c4aa5f93d57db68bbc08cb80f9a0504388a434755a8394b7a0ed4ab7ddcf1d7eR55
https://github.com/openshift/release/pull/54079/files#diff-c4aa5f93d57db68bbc08cb80f9a0504388a434755a8394b7a0ed4ab7ddcf1d7eR37

Can you update them?

@ashwindasr ashwindasr force-pushed the sriov-network-operator-rename-dockerfile branch from 8dbc757 to dfacb61 Compare July 10, 2024 18:09
@ashwindasr
Copy link
Contributor Author

Thanks @zeeke, I've updated and repushed. ptal when you get the chance

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@ashwindasr: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-sriov-network-operator-master-api openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-ci-index-sriov-network-operator-bundle openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-controllers openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-e2e-openstack-nfv openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-e2e-openstack-nfv-hwoffload openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-e2e-telco5g-cnftests openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-gofmt openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-images openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-operator-e2e openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-pkg openshift/sriov-network-operator presubmit Ci-operator config changed
pull-ci-openshift-sriov-network-operator-master-security openshift/sriov-network-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@zeeke
Copy link
Contributor

zeeke commented Jul 11, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2024
@zeeke
Copy link
Contributor

zeeke commented Jul 17, 2024

/approve
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@zeeke: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 17, 2024
@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 16, 2024
@openshift-bot
Copy link
Contributor

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 1, 2024
@zeeke
Copy link
Contributor

zeeke commented Sep 2, 2024

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0c331b0 and 2 for PR HEAD dfacb61 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2024

@ashwindasr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e796bb2 into openshift:master Sep 2, 2024
MiguelCarpio pushed a commit to MiguelCarpio/release that referenced this pull request Sep 4, 2024
giladravid16 pushed a commit to giladravid16/release that referenced this pull request Sep 5, 2024
MiguelCarpio pushed a commit to MiguelCarpio/release that referenced this pull request Sep 12, 2024
obochan-rh pushed a commit to obochan-rh/release that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants